News for hackers. Stuff that matters.
Re:Maintaining code quality when nobody cares by pjc50 on Tuesday February 13, 2018 @09:30AM (#16367339)
> willingness to throw away work becomes a mark of pride at some places

Is this a typo for "willingness"?

Code review is important not just for preventing junk from entering the codebase but for ensuring that someone else has seen the thing and has some idea of how it works. I agree that "pull request" is the wrong terminology for a commercial environment.

Re:Maintaining code quality when nobody cares by tboyd47 on Tuesday February 13, 2018 @09:44AM (#16367449)
Understood. It's just that the PR model only encourages that code review to happen at the very end of the process, when the submitter may have been polishing their work, testing it, and refining it for several days. It would be more efficient for it to occur periodically throughout development, rather than at the very end.
Re:Maintaining code quality when nobody cares by house9-2 on Tuesday February 13, 2018 @10:53AM (#16368044)
I usually create a PR after the first commit and mark the PR as a WIP, then it is available for review throughout the development process. YMMV