News for hackers. Stuff that matters.
Re:Ask HN: Started a new job and their existing code sucks. ... by microtherion on Thursday January 25, 2018 @06:58PM (#16235926)
First at all, something akin to Chesterton's fence applies. Somebody new to an organization rarely understands all the factors that go into a code base, and even if they're right that the code base is bad, they are generally not yet equipped to safely fix it.

Second, this might be a first for you, but a new person coming in and deciding that the current code base is unsalvageable and needs to be completely rewritten is pretty much a cliché in our industry.

So what would I do? Like cheshireoctopus said, you can leave each bit of code you touch a bit cleaner than you encountered it. You can also try to get approval to start writing tests — having a test suite in place will first help you understand the existing code through and through, and then provide a safety net once you get around to proceeding to the actual refactor.

Re:Ask HN: Started a new job and their existing code sucks. ... by mythrwy on Thursday January 25, 2018 @08:42PM (#16236411)
I agree but sometimes the whole thing is so clown shoes from the ground up it just plain isn't going to work as is. That does happen.
Re:Ask HN: Started a new job and their existing code sucks. ... by jf22 on Friday January 26, 2018 @01:20PM (#16241525)
Its obviously working if the company is hiring right?
Re:Ask HN: Started a new job and their existing code sucks. ... by atmosx on Saturday January 27, 2018 @06:22PM (#16248684)
> Second, this might be a first for you, but a new person coming in and deciding that the current code base is unsalvageable and needs to be completely rewritten is pretty much a cliché in our industry.

Amen.