Re:How I review code
by cobbzilla on Wednesday January 24, 2018 @10:12AM
(#16223243)
If you know your team well, it will help you keep an eye out for common mistakes they've made in the past. It may also help adjust your tone, as developers you've worked with for a long time will understand light humor or other well-intended comments that might be read as off-putting by newer devs.
[ Parent
| on HN ]
Re:How I review code
by darkerside on Thursday January 25, 2018 @09:54PM
(#16236705)
The anti-pattern to avoid here is assuming code written by senior engineers is inherently "better" in some way than that by a junior. Yes, it typically is, but the code should speak for itself. Ad hominem assumptions add little value.
Similar to blind testing in musical auditions. http://gap.hks.harvard.edu/orchestrating-impartiality-impact...