Death metal is surprisingly conducive to productive work. I mostly like music with a heavy repetitive beat and minimal lyrical content.
The music I find effective drowns out surroundings and distracts the mind a bit while being very simple and repetitive so that it does not engage too much mental energy.
I really like classical music but find it to be no good for programming because it is to varied and complex and so i will get distracted in appreciating the musical composition.
I enjoy a full range of musical genres and I typically go in cycles. I'll go for a week or two on trance/progressive (A State of Trance Episodes 300-450). Then I might switch to technical death metal for a bit. Even though they typically sing in English, it turns out that the lyrical content of this type of music is hardly discernable. I also happen to enjoy a lot of punk and hardcore music. I find that if I already know the words to the music, then sometimes it's not as distracting as other lyrically-heavy genres.
Also, I'd suggest investing a pair of good over-the-ear headphones (if you can tolerate them) or at least a pair of good in-ear earphones. You might also consider an amplifier as well. With my iPod classic, an amp, and my Beyerdynamic DT-770s, the music sounds so damn good. The seal on my ears is so tight that I'm basically isolated from my environment.
Same now, as an adult, although obviously it's much easier to have self-control and ignore noises as an adult :-)
I don't think this is unusual at all; heck, my musical upbringing tends to mean that if there isn't music playing, my brain fills in the gap with one song on loop. Sometimes I need to switch the mental track, y'know?
When concentrating I often listen to classical piano now, composers such as Erik Satie.
I found the modern music was great for coding but if I was writing the classical was better, I suppose the vocals muddled my language train for writing.
Hearing other people talking (musically or otherwise) competes for some of the same neurons.
I use music to mask open office noise including customer support personnel on phone calls, ops people discussing equipment failures, and political trolls discussing my preferred party.
Industrial, death metal, and recordings of rainfall all work just as well for me. Though in the case of rainfall I find about twenty minutes of the same sound is about my limit before I need more texture in my auditory diet. Silence just makes my ears ring louder until after a few minutes it is physically painful to not have some noise.
The issue of masking background conversations was not covered. I find that wearing isolating earphones, earmuffs, etc only serves to strain me further since I can still hear conversations but I have to listen harder to make out the words.
Perhaps I have some undiagnosed anxiety or paranoia but for me, isolation/silence does not work as well as masking.