News for hackers. Stuff that matters.

A comment on Show HN: Golang DNS server, including DNSSEC and DNS-over-TLS. Parent comment

Re:Show HN: Golang DNS server, including DNSSEC and DNS-over... by pokstad on Tuesday November 28, 2017 @12:35PM (#15799388)
No, tests are commonly in the same package as the implementation.

I did find this one: https://github.com/tenta-browser/tenta-dns/blob/master/src/t...

That's an internal test, meaning it has access to the package internals. A better test would test from outside the boundaries of the package to only interact with exposed symbols.

[ Parent | on HN ]
Re:Show HN: Golang DNS server, including DNSSEC and DNS-over... by alpb on Tuesday November 28, 2017 @12:37PM (#15799414)
Oh lordy, that log.SetLogLevel() has effects outside the test code.
[ Parent | on HN ]
Re:Show HN: Golang DNS server, including DNSSEC and DNS-over... by tenta on Tuesday November 28, 2017 @12:45PM (#15799488)
Setting the log level has effects, but only on an internal wrapper package that neatly zips up the nitty gritty of setting up the logger.
[ Parent | on HN ]
Re:Show HN: Golang DNS server, including DNSSEC and DNS-over... by sagichmal on Tuesday November 28, 2017 @07:34PM (#15803431)
Package-level loggers are an antipattern :(
[ Parent | on HN ]