News for hackers. Stuff that matters.
Re:Using “and” and “or” in Ruby by KirinDave on Monday August 02, 2010 @12:58PM (#1568166)
Except that it's not obscure at all. "and" and "or" exist specifically to facilitate this kind of code. That's their primary purpose.

And it's not like that's exactly unusual in the ruby language. Post-conditionals have a similar low precedence.

Re:Using “and” and “or” in Ruby by prodigal_erik on Monday August 02, 2010 @02:29PM (#1568527)
I'm starting to worry how much cargo-cult work must be happening in Ruby, if operators that have been in the precedence table for years are considered to be something obscure that you'll eventually discover.
Re:Using “and” and “or” in Ruby by seabee on Monday August 02, 2010 @05:04PM (#1569075)
Not only that, but operators which are hardly unique to that language (hello Perl).
Re:Using “and” and “or” in Ruby by aneth on Thursday August 05, 2010 @06:24PM (#1579538)
Yes, Perl is a great example of a language that enables maintainable clear code.
Re:Using “and” and “or” in Ruby by acgourley on Monday August 02, 2010 @02:19PM (#1568487)
Is "this kind of code" worth it? It certainly is aesthetically pleasing and somewhat terse compared to a parenthesis jungle. But that does outweigh the fact non-experts don't know exactly what the statement is doing?
Re:Using “and” and “or” in Ruby by sketerpot on Monday August 02, 2010 @02:27PM (#1568515)
To anyone who learns the idiom, this code is fine, and perfectly readable. I don't even know Ruby yet, and it took me less than a minute to become fully comfortable with this kind of code. This isn't a huge barrier to "non-experts".
Re:Using “and” and “or” in Ruby by CodeMage on Monday August 02, 2010 @02:33PM (#1568539)
It's always easy to claim something is okay when you "don't even know [language] yet", isn't it? ;)

All joking aside, the problem with this is not that "non-experts" don't understand what the code does at all. It's that they don't understand all that it does. If you never read anything that warns you about the difference between "and/or" and "&&/||" (or if you skim over it), it can bite you really bad.

Re:Using “and” and “or” in Ruby by acgourley on Monday August 02, 2010 @03:40PM (#1568766)
Of course it took under a minute, you were reading a nice blog post on the topic. The problem is not every instance of 'and' will include that information. And so I worry that if I drop 'and' into some minor glue script I write - it becomes less self documenting to my coworkers. It's a minor point, but it can become a slippery slope (see: perl)
Re:Using “and” and “or” in Ruby by KirinDave on Monday August 02, 2010 @03:51PM (#1568804)
This entire argument is moot. No one cares how obscure a language looks to someone who is not familiar with it. Do you regularly sit down and decide, “I am going to use a language I don't know to accomplish something essential and immediate?” And even if the answer is yes, then do you still not know the language at the end of that exercise?

This is a very simple, easily understandable and easily readable feature of Ruby. It's not obscure, complex, or even that unusual. Precedence is something every competent programmer needs to understand, and it should be part of every programmer's research to learn a new language. After all, this is a conversation about the existence of "and" & "or", not their abuse.

Re:Using “and” and “or” in Ruby by Roboprog on Tuesday August 03, 2010 @10:20AM (#1571210)
I used to be competent, but now I guess I avoid writing stuff that relies on any knowledge of operator precedence.

I try to learn what I can of such precedence in the language of the day, since I will have to maintain other people's "code" (cypher?), but I try to write obvious "programs" (who is in this play, what are the acts?).

I've been at this over 2 decades, and it's much easier to read something that uses a few parentheses, a well named intermediate variable or two, or even a few functions, than it is to read bunch of multiple operators on the same line gobble-de-gook. Watching somebody else generate a hundred thousand dollars of wasted product in a manufacturing preparation process a few years back, due to such a run-on if-statement being fouled up, was also a good confirmation of this bias. I'm sure my current job in finance offers similar opportunities for expensive blunders.

Re:Using “and” and “or” in Ruby by chc on Monday August 02, 2010 @02:43PM (#1568568)
If by "non-experts" you mean "people who have hardly any familiarity with the language at all," then yes, I'm OK with people who don't know the language not understanding code written in that language.

I agree that we should not write code only for experts, but that doesn't mean we should take the absolute opposite approach and refuse to use case statements or blocks because somebody might read our code without bothering to learn the basics of the language.

Re:Using “and” and “or” in Ruby by acgourley on Monday August 02, 2010 @03:37PM (#1568761)
The use case I'm thinking of is when I'm using my scripting language of choice to write some glue code and I want other people in the organization to be able to grok it easily. Perhaps Python is really the better choice for those tasks, but so often these days my choice of scripting language for task X depends on the state of libraries I plan on using. And ruby does have better libraries from many tasks.

I agree that if you're writing a medium to large technology stack, you should take it as an assumption only proficient users of the language will hack on it.

Finally, I disagree with your assertion that only people with "hardly any familiarity with the language at all" would not know the order of operation difference between && and 'and'. I think the popularity of this story on this site speaks to that.

Re:Using “and” and “or” in Ruby by jamesbritt on Monday August 02, 2010 @04:42PM (#1568986)
"But that does outweigh the fact non-experts don't know exactly what the statement is doing?"

That thinking can cover a whole lot of code, and raises the question of what defines an expert?

Use the whole language; people become experts by experiencing new things.

The guidelines should be, can you yourself still read and understand it a month later, and do you find that a particular idiom tends to make bugs easier or harder to find.

Re:Using “and” and “or” in Ruby by CodeMage on Monday August 02, 2010 @02:30PM (#1568529)
Depends on what you call "this kind of code". Operators like "and" and "or" facilitate some very useful and expressive idioms, so having that kind syntactic constructs is rather useful.

However, I think it's a big mistake to make those constructs use "and" and "or", because it overloads the semantics normally associated with those keywords. Yes, it's true that it's precisely the same logic under the hood, but you have to fight the "oh, boy, that's so neat!" reflex and think about all that could go wrong.

There's a similar gotcha in Python, where instead of ternary operator (a ? b : c) you use a combination of "and" and "or" (a and b or c). The gotcha is that it backfires if "b" evaluates to false.

All in all, it's probably not "worth it" to have nasty surprises like that, but that could be avoided by using different keywords, not "and" and "or".

Re:Using “and” and “or” in Ruby by anthonyb on Monday August 02, 2010 @08:28PM (#1569639)
In Python, the side effects were considered so nasty that they finally added ternary operators in 2.6. The syntax goes like:

    x = 'foo' if foo else bar
which is at least more readable than the C/PHP/Ruby equivalent.
Re:Using “and” and “or” in Ruby by steveklabnik on Monday August 02, 2010 @10:42PM (#1569910)
You can do

     x = if foo then 'foo' else 'bar' end
in Ruby, if you'd like.
Re:Using “and” and “or” in Ruby by stevejohnson on Monday August 02, 2010 @04:20PM (#1568908)
I just want to briefly mention that I am only on the third chapter of the Poignant Guide, hardly what you'd call an expert, and I already understand completely what is going on in the top comment's example. I know why. But maybe that's because it acts pretty much like Python with anonymous functions in this case.

And no, I haven't read the original post yet. I was doing a skim-the-comments-before-reading run,

Re:Using “and” and “or” in Ruby by jseifer on Monday August 02, 2010 @03:29PM (#1568736)
Exactly, it's a language feature. That would be similar to calling the conditional assignment (||=) operator obscure.
Re:Using “and” and “or” in Ruby by telemachos on Monday August 02, 2010 @09:48PM (#1569804)
I agree with your larger point, but you may not have the best example. ||= is notoriously obscure in Ruby - in details at least.

http://www.ruby-forum.com/topic/151660/

Re:Using “and” and “or” in Ruby by acgourley on Monday August 02, 2010 @04:29PM (#1568937)
The issue is that ||= doesn't have a spelled out synonym like && has 'and'.
Re:Using “and” and “or” in Ruby by KirinDave on Tuesday August 03, 2010 @12:14AM (#1570102)
That said... &&= might be deemed obscure. Even experienced rubyists seem confused when I use it.