Re:Why GitHub Can't Host the Linux Kernel Community
by chungy on Thursday August 10, 2017 @02:37AM
(#14977039)
> I'm just starting to accept patches for my project, and honestly I'm flabberghasted that people will send patches that not only don't run, but don't build. And Greg was saying the same thing.
Indeed, I've seen the same thing. I have considered automatically rejecting any patch made with the GitHub online editor (obvious because the committer name is always GitHub). They are pretty much invariably of shit quality.
Re:Why GitHub Can't Host the Linux Kernel Community
by simonh on Thursday August 10, 2017 @11:42AM
(#14980783)
That's fair enough. The only times I've submitted patches that way is to update documentation files. I'd never submit code that way.
Re:Why GitHub Can't Host the Linux Kernel Community
by tytso on Wednesday August 09, 2017 @11:58PM
(#14976209)
Linaro isn't a company; it's a "collaborative engineering organization". It does employ some number of engineers, funded by donations by their member companies, but they also accept "in-kind" donations where engineers are detailed to work at Linaro for some period of time. So it wasn't really directed at Linaro per se, but more at the member companies of Linaro.
He's at Linaro, specfically taking their developers to task for sending bad patches. And they indeed sound horrible, but he's good natured about it.
I'm just starting to accept patches for my project, and honestly I'm flabberghasted that people will send patches that not only don't run, but don't build. And Greg was saying the same thing.
I guess I got spoiled at my last job, where people generally sent high quality patches / code reviews. Although toward the end, I noticed some sloppiness. It wasn't the main reason I left the company, but it started to feel like the downfall... I don't want to work with people who don't know how to submit code reviews / patches.