News for hackers. Stuff that matters.
[dead]
Re:Yahoo reinvented inline styles through classes by _Marak_ on Sunday July 23, 2017 @03:58PM (#14834079)
For everyone reading these comments, I want to say that this kind of pull request is hurtful and unwarranted.

You've essentially sent an alert to someone ( or a group of people ) saying that you believe their work has no value. This kind of behavior could have real-world consequences. You could be pushing someone to not work on open-source again, or make them feel worse about working on a project they might be required to contribute to as part of their job.

How would you feel if someone started vandalizing your own github projects gvx? Would it make you feel good? Would you consider it funny?

Re:Yahoo reinvented inline styles through classes by gvx on Sunday July 23, 2017 @05:23PM (#14834476)
It was intended as an innocent tongue-in-cheek joke, not to insult or vandalise. In that, I've failed completely. I can see that now.

I'm closing the pull request with an apology.

Re:Yahoo reinvented inline styles through classes by jayair on Sunday July 23, 2017 @06:25PM (#14834739)
I'm glad this is being called out. Thank you.
Re:Yahoo reinvented inline styles through classes by ghrifter on Monday July 24, 2017 @03:03PM (#14841573)
First day on the internet?
Re:Yahoo reinvented inline styles through classes by pier25 on Sunday July 23, 2017 @04:24PM (#14834207)
So because some people might take criticism personally we shouldn't be allowed to express criticism?
Re:Yahoo reinvented inline styles through classes by matt_kantor on Sunday July 23, 2017 @04:46PM (#14834289)
You're allowed to be a jerk, but when doing so you shouldn't be surprised if people call you a jerk (or use a nicer phrase like "this kind of pull request is hurtful and unwarranted").

Constructive criticism is good, but the linked PR is not that. It's akin to a content-less drive-by HN comment like "you suck". You're free to post it (until you get banned), but it's not adding anything and you should expect downvotes.

Re:Yahoo reinvented inline styles through classes by pier25 on Sunday July 23, 2017 @05:18PM (#14834447)
I agree with you and I'm not saying "delete your fucking project" is constructive criticism.

But, if an internet stranger says "delete your fucking project" and you take that personally there's no one to blame for your suffering than yourself.

Also, _Marak_'s paternalistic comment would make sense with a group of 10 year olds, but we are all adults here.

Re:Yahoo reinvented inline styles through classes by nicky0 on Sunday July 23, 2017 @05:54PM (#14834619)
If you don't want to be treated like a 10 year old then don't act like one.
Re:Yahoo reinvented inline styles through classes by pier25 on Sunday July 23, 2017 @07:06PM (#14834847)
I'm sorry, could you explain what part of what I said was infantile?
Re:Yahoo reinvented inline styles through classes by romanovcode on Sunday July 23, 2017 @04:44PM (#14834278)
This kind of criticism has 0 value. It basically says "you suck!". OP needs to grow up.
Re:Yahoo reinvented inline styles through classes by pier25 on Sunday July 23, 2017 @05:18PM (#14834450)
I asked a question because I want to start a debate, which is quite different.
Re:Yahoo reinvented inline styles through classes by Frondo on Sunday July 23, 2017 @06:59PM (#14834831)
I'm going to go a bit farther and say: correct, for non-constructive criticism, on HN, you shouldn't be allowed to express it.

The community values here don't support or endorse non-constructive criticism, and I am OK in saying that simply shouldn't be allowed.

There are other venues for that stuff, this isn't one of them.

Re:Yahoo reinvented inline styles through classes by coke12 on Sunday July 23, 2017 @03:44PM (#14834005)
Why would you do this?
Re:Yahoo reinvented inline styles through classes by treve on Sunday July 23, 2017 @03:48PM (#14834024)
You're an awful person.
Re:Yahoo reinvented inline styles through classes by winstonewert on Sunday July 23, 2017 @03:42PM (#14833997)
You could at least ensure the CI tests still pass. :P
Re:Yahoo reinvented inline styles through classes by juanpotato on Sunday July 23, 2017 @03:48PM (#14834025)
No need for tests to pass if they don't exist ¯\_(ツ)_/¯
Re:Yahoo reinvented inline styles through classes by awinder on Sunday July 23, 2017 @03:51PM (#14834045)
Need to provide tests to make sure that the original problem doesn’t crop up again ;-)