News for hackers. Stuff that matters.

A comment on Engineering management lessons (2014). Parent comment

Re:Engineering management lessons (2014) by watwut on Saturday May 20, 2017 @06:38AM (#14381758)
Code reviews by a dude who codes only a little and has formal power are pure hell. It is tricky when he is wrong, he can force you to do things that cause trouble and so on and so forth - all that because writing and reviewing code are much different and he is gradually out of touch.
[ Parent | on HN ]
Re:Engineering management lessons (2014) by sanderjd on Saturday May 20, 2017 @11:31AM (#14382826)
It sounds like you've run into some bad apples, likely due to "promoted too early" syndrome, which is unfortunately pretty common. In my experience, code review by senior engineers is extremely valuable whether or not they're currently writing much code.
[ Parent | on HN ]
Re:Engineering management lessons (2014) by Spooky23 on Saturday May 20, 2017 @01:35PM (#14383432)
That's why coding managers is dumb.

The army figured it out. The Officers are in charge, but the sergeants get shit done. In engineering, your leads/supervisors are the sergeants.

Officer quality varies between complete shitbird and Julius Ceasar. Either way, the army marches.

[ Parent | on HN ]
Re:Engineering management lessons (2014) by dismantlethesun on Saturday May 20, 2017 @02:26PM (#14383615)
Sound like tech leads are sergeants and project managers are officers.
[ Parent | on HN ]
Re:Engineering management lessons (2014) by Spooky23 on Saturday May 20, 2017 @02:36PM (#14383659)
That's where the analogy breaks a bit. Where I work, PMs don't "own" people, just deliverables.

Their main weapon is pestering you.

[ Parent | on HN ]
Re:Engineering management lessons (2014) by pkaye on Saturday May 20, 2017 @11:31AM (#14382828)
The bigger problem is other reviewers assume that if the manager approves the review then there is no need for them to do as thorough a review.
[ Parent | on HN ]
Re:Engineering management lessons (2014) by valuearb on Saturday May 20, 2017 @11:02AM (#14382679)
Why did you code it that way?

How hard is it to answer that question?

[ Parent | on HN ]
Re:Engineering management lessons (2014) by NortySpock on Saturday May 20, 2017 @11:19AM (#14382749)
"It will cause performance problems if you don't" , with only a gut feeling to back it up, and no actual testing.

I just ran into this response yesterday, and I ended up going over his head (unfortunately) and asked our DBAs for a recommendation. DBA solution worked faster than either of the previous two solutions. I still need to apologise for that one.

[ Parent | on HN ]
Re:Engineering management lessons (2014) by mncharity on Sunday May 21, 2017 @12:48AM (#14385739)
> I still need to apologise for that one.

Curious. Running an idea by people to get their thoughts, because it's currently leaving you short on warm fuzzies... is something to apologize for?

The initial solution was low on warm fuzzies for him. Your second solution was low on warm fuzzies for you. So you explored further. Where's the problem?

[ Parent | on HN ]