Re:Ask HN: How do you evaluate a job offer and the company o...
by cpfohl on Tuesday March 28, 2017 @02:11PM
(#13979070)
How do you look at a company's code before you get on the job? I've never been in a situation where my company or my company's clients would have been ok with that.
Re:Ask HN: How do you evaluate a job offer and the company o...
by EamonnMR on Tuesday March 28, 2017 @02:12PM
(#13979091)
Some big companies have open source libraries you can check out. Smaller companies not so much.
Re:Ask HN: How do you evaluate a job offer and the company o...
by edw519 on Tuesday March 28, 2017 @02:12PM
(#13979093)
Insist on it! I can't tell you how sorry I hadn't done this sooner.
If they won't comply, that's a big red flag. Run the other way.
Re:Ask HN: How do you evaluate a job offer and the company o...
by aratno on Tuesday March 28, 2017 @02:16PM
(#13979135)
In most industries, this is not a red flag at all. Nobody doing anything serious would let normal applicants look openly at their codebase.
Re:Ask HN: How do you evaluate a job offer and the company o...
by Etheryte on Tuesday March 28, 2017 @03:11PM
(#13979679)
You don't have to (and should not) request access to the whole codebase, simply asking to see a single medium sized file from a project you would be expected to work with is often enough. I've asked for this before with great success, some companies will ask you to sign a short NDA beforehand, most don't even bother. Sure, it leaves the chance that they will simply show you the pretty parts, but at least you'll know that there are some pretty parts at the very least.
Re:Ask HN: How do you evaluate a job offer and the company o...
by abulman on Tuesday March 28, 2017 @03:26PM
(#13979809)
Much of the time, the software isn't what makes for a great company - it's how that software makes the business work. A company can have the best code in the world, but if Uber had no cars, AirBNB had no houses, or Facebook didn't have your friends - they would be pointless.
Re:Ask HN: How do you evaluate a job offer and the company o...
by metaphorm on Tuesday March 28, 2017 @03:10PM
(#13979666)
I'm not sure if you're serious or not. A small company selling a proprietary software product ABSOLUTELY WILL NOT EVER UNDER ANY CIRCUMSTANCES show you their code before you've signed contracts.
Re:Ask HN: How do you evaluate a job offer and the company o...
by gregshap on Tuesday March 28, 2017 @11:08PM
(#13983024)
I've never had someone ask this, but I would offer to let them browse some code and recent PRs on my laptop while I sit alongside.
Re:Ask HN: How do you evaluate a job offer and the company o...
by joatmon-snoo on Tuesday March 28, 2017 @02:50PM
(#13979477)
If they won't comply, that means someone read their employment contract and non-disclosure agreements.
Re:Ask HN: How do you evaluate a job offer and the company o...
by lutorm on Tuesday March 28, 2017 @02:41PM
(#13979382)
But I will never refactor another 800 line case statement with 26 early exits, 14 double negatives, and 90 unintelligible variable assignments inside a 23,000 line module. Never.
But there's the sign that they really need you.
Re:Ask HN: How do you evaluate a job offer and the company o...
by JamesSwift on Tuesday March 28, 2017 @03:22PM
(#13979770)
Paraphrasing JFK:
"We pay you the big bucks not because what you do is easy, but because it is hard"
Re:Ask HN: How do you evaluate a job offer and the company o...
by bb88 on Tuesday March 28, 2017 @10:29PM
(#13982832)
I'm not sure you can ever adequately analyze the code in the amount of time needed to make a decision -- unless the code is less than say 20,000 lines.
Any company of reasonable size will have ugly code bases somewhere, someplace, hidden in the dark reaches that nobody wants to touch because it was written 5 years ago and no one who wrote it is around anymore.
I don't like jerk bosses, difficult customers, unrealistic deadlines, lack of specs, reqs, or schedules, tough commutes, or unreasonable pay, but over the years, I've learned to live with them.
I have never learned to live with shitty code.
I'll answer your phones. I'll clean your toilets. I'll even take your daughter to the movies.
But I will never refactor another 800 line case statement with 26 early exits, 14 double negatives, and 90 unintelligible variable assignments inside a 23,000 line module. Never.
I wish I had adopted this philosophy years ago. Oh how much better my life would have been.