Re:Ask HN: I got duped into working on legacy code, should I...
by db48x on Monday March 20, 2017 @01:31AM
(#13911955)
The depth of the stack is not a very good metric for code quality.
[ Parent
| on HN ]
Re:Ask HN: I got duped into working on legacy code, should I...
by masor on Monday March 20, 2017 @01:41AM
(#13911996)
Why is everyone quibbling with him about that. He just wants to express his opinion that the codebase is very bad in a more colorful way than by simply calling it doubleplusbad. Let's just take his word for it and move on.
Re:Ask HN: I got duped into working on legacy code, should I...
by reitanqild on Monday March 20, 2017 @02:09AM
(#13912117)
Because we are trying to tell OP in a nice way something we think he will benefit a mot from rather than just what he seems to be wanting?
Re:Ask HN: I got duped into working on legacy code, should I...
by throwawaysbdi on Monday March 20, 2017 @02:22AM
(#13912162)
It's bad in a lot of specific ways but I'm trying not to out myself since it's a fairly small company.
The overarching problem is trying to reinvent the wheel because the management thinks we can do things better than the language designers.
The end result is a buggy and generally bad reimplementation of core libraries. ORM, math, dates, full text search. There's a half-baked custom version of everything.
Re:Ask HN: I got duped into working on legacy code, should I...
by macca321 on Monday March 20, 2017 @09:53AM
(#13914191)
Add regression tests, replace with your own code. or quit.
Re:Ask HN: I got duped into working on legacy code, should I...
by xiphias on Monday March 20, 2017 @11:14AM
(#13914856)
That's the worst thing to do: doesn't provide any value at the part that matters.
It may worth to improve code quality where it matters (the business logic), but to improve it where it doesn't matter is a waste of time to both the employee and the employer
Re:Ask HN: I got duped into working on legacy code, should I...
by reitanqild on Monday March 20, 2017 @12:54PM
(#13915689)
I would think this was implied:
Only noobs like myself years ago would go ahead and refactor a lot of code during work hours without a good reason.
However when you stumble through something and finally understand the idea behind it (good or bad) then it might be a good time to add a couple of tests.
And when you have a few tests that covers nearby code you can hopefully find the courage to make a few surgical cuts to remove the worst tumors. ;-)