> What puzzles me is this: how do the republicans, either under Trump or any of their predecessors get people to consistently vote against their interests?

Because they are voting based on tribalism. Trump signaled that he was a member of their tribe with his "tough talk" and racist comments. It doesn't matter what he does now - what the voters cared about was that "their team won."