> I wonder if it's an NYC thing.

I think it's a US thing.

I remember that when I was younger I would get asked those questions every time, but not any more.

In the past few years (decade?) there has been a lot of push back against upselling fast food due to obesity concerns. If I had to guess I would say it probably started around when the movie "Super Size Me" was released (2004).

Now, if I order a meal, I might get asked "what size" without any suggestion. Or if I order a sandwich by name, I usually get asked to clarify if I want "the meal or just the sandwich." But I can't remember the last time they actually tried to upsell me.

It wouldn't surprise me in the least if upselling still happened outside of the US.

Nope. Small Midwestern town, same deal.