News for hackers. Stuff that matters.
Re:Android Project Changeset 4f8b683: libc/memset.c by justinweiss on Tuesday May 25, 2010 @07:47PM (#1379043)
memset sets a block of memory to a given value. It is often used to initialize an uninitialized block of memory to 0. So often, in fact, that this bug where it always initialized the memory to 0 survived so long.
Re:Android Project Changeset 4f8b683: libc/memset.c by abstractbill on Tuesday May 25, 2010 @08:23PM (#1379109)
So often, in fact, that this bug where it always initialized the memory to 0 survived so long.

Given that the bug went undetected for so long, I think you could almost reasonably claim that calling memset with a nonzero parameter is a "corner case" ;)

Re:Android Project Changeset 4f8b683: libc/memset.c by Psyonic on Thursday May 27, 2010 @06:12PM (#1385093)
It is a "corner case," or close to it, but that's not why it wasn't caught here. I don't think this code is ever called, as explained above. It's default code in case there isn't a platform specific version, but there pretty much always is a platform specific version.

Link: http://news.ycombinator.com/item?id=1379639

Re:Android Project Changeset 4f8b683: libc/memset.c by fserb on Tuesday May 25, 2010 @08:45PM (#1379165)
on Google code search: "lang:c memset\(.+,\s[^0]+\s,.+\)" return 32k results and "lang:c memset\(.+,\s0+\s,.+\)" returns 335k.
Re:Android Project Changeset 4f8b683: libc/memset.c by wlievens on Wednesday May 26, 2010 @03:14AM (#1379718)
10% is a lot more than I would have thought, wow. Good job looking that up.
Re:Android Project Changeset 4f8b683: libc/memset.c by mey on Tuesday May 25, 2010 @07:56PM (#1379061)
Wish there was a cross-link to a bug tracking system where this was initially reported.
Re:Android Project Changeset 4f8b683: libc/memset.c by pufuwozu on Tuesday May 25, 2010 @08:00PM (#1379067)
You can just search for the change ID:

https://review.source.android.com/#change,14699