News for hackers. Stuff that matters.
Re:React Tetris by efdee on Saturday February 04, 2017 @06:37AM (#13566635)
I really enjoyed playing this clone. Well done!

That being said, I took a look at the code and the way Redux is being used feels kind of weird to me - pretty much a separate reducer for every kind of action.

Re:React Tetris by thomasfl on Saturday February 04, 2017 @07:33AM (#13566756)
Agree. Besides that most reducers only merges in variables from an action to the global state. I guess this could be done much simpler.

Example: https://github.com/chvin/react-tetris/blob/master/src/reduce...

Re:React Tetris by kolme on Saturday February 04, 2017 @09:26AM (#13567065)
The game looks great, but the code is overly over engineered. I've written a bunch of tetris clones in my time and it never felt this complex.
Re:React Tetris by elldoubleyew on Saturday February 04, 2017 @11:33AM (#13567551)
I think primary focus of this project was to showcase proper Redux implementation. There certainly are much easier ways to accomplish Tetris but that is not what they were shooting for.
Re:React Tetris by babbeloski on Saturday February 04, 2017 @03:12PM (#13568790)
Only connecting the root component, fetching the entire state, and passing down all those props manually isn't proper. You shouldn't pass props that can be grabbed directly from the store IMO.