Re:About pull request reviews
by jtietema on Friday December 09, 2016 @04:51AM
(#13137773)
so true, it lacks an inbox feature like Bitbucket Server (Atlassian Stash) has. On top of that:
- keeping track of changes over the life time of a PR is impossible, you have review the whole thing over and over again
- toggle notes (comments) on a per file basis is silly and unpractical on PR's with lots of files and comments.
- there is no way to see which PR from a list you already approved.
And the list goes on and on. I have been using Github Enterprise at my new job since recently and it is by far the poorest of tools I have ever used to review code.
- keeping track of changes over the life time of a PR is impossible, you have review the whole thing over and over again - toggle notes (comments) on a per file basis is silly and unpractical on PR's with lots of files and comments. - there is no way to see which PR from a list you already approved.
And the list goes on and on. I have been using Github Enterprise at my new job since recently and it is by far the poorest of tools I have ever used to review code.