News for hackers. Stuff that matters.
Re:About pull request reviews by mugsie on Thursday December 08, 2016 @06:57AM (#13129787)
but the code could completely change in the next revision ... making the review pointless.
Re:About pull request reviews by stepanhruda on Thursday December 08, 2016 @07:41AM (#13129925)
It could but most orgs can assume good actors, and always resetting would slow the process down.
Re:About pull request reviews by mugsie on Thursday December 08, 2016 @07:52AM (#13129963)
Not resetting would seem to make the review process moot.

If you want speed, just allow everyone to merge

Re:About pull request reviews by stepanhruda on Thursday December 08, 2016 @08:33AM (#13130143)
No, you want a review, but can trust that people will ask for re-review if they make significant changes. If you want to completely stop people from comitting malicious code, resetting the review process is a weak safeguard.
Re:About pull request reviews by mugsie on Thursday December 08, 2016 @09:22AM (#13130397)
eh ... if you want to audit code being committed (and for open source projects - you really do, or if you have SOX compliance regulations, or other audit processes) it is one of the best safeguards.

I have seen many many bugs being introduced as part of a fix for a review comment.

This is why you re-review.