News for hackers. Stuff that matters.

A comment on Ripgrep code review. Parent comment

Re:Ripgrep code review by mbrt on Monday December 05, 2016 @01:20PM (#13107769)
blog author here. Thanks for your feedback, I appreciate that! I'm gonna edit the post with it. And don't worry about your code... it's the best crate I've seen so far ;)

By the way, shouldn't msys_tty_on_handle be marked 'unsafe' too? I'm wondering if what happens I pass in some garbage as a handle...

[ Parent | on HN ]
Re:Ripgrep code review by burntsushi on Monday December 05, 2016 @08:01PM (#13111385)
> By the way, shouldn't msys_tty_on_handle be marked 'unsafe' too? I'm wondering if what happens I pass in some garbage as a handle...

Possibly. How would you construct said garbage? Would it require unsafe?

[ Parent | on HN ]
Re:Ripgrep code review by mbrt on Tuesday December 06, 2016 @06:14AM (#13113763)
I'm not sure, probably yes. It all depends on the winapi crate. If you can get an handle of a different "type" than the expected one, then it's garbage for GetFileInformationByHandleEx. Probably you can't do it without unsafe, so maybe it's fine.
[ Parent | on HN ]