I've only seen Electron-based editors doing metrics, perhaps web developers are less offended by the idea thanks to pervasive usage of things like Google Analytics.
Collecting call stacks from crashing threads or executables can be incredibly useful for fixing them.
Measuring what functionality gets used and what not can help direct feature development (should that checkbox be as visible as it is?)
Collecting statistics on Unicode code point usage may direct development of core data structures (UTF-16 might be the best choice for the basic character unit)
Collecting CPU/memory/disk stats similarly may direct development (if most of your users have gigabytes of free RAM, that change that takes 20% more memory but speeds up things may be useful; if they have plenty of idling CPU! But no memory, things are different)
Knowing what percentage of your users run on a 80386 may help making the decision to compile for at least a 80486.
Knowing internet connection speed and amount of free disk space may help make the decision to move all help online.
Knowing the default browser can help direct testing of the help system, if that system uses the default browser.
Knowing the locale of your users may give hints as to what spell checking languages or UI translations to support.
Having access to the custom dictionaries of all your users may be helpful in improving the ones you ship with the editor.
Having access to every edit made (we are deeply into 'extremely privacy invading' territory now) may also be helpful. For example, you may discover that most of your users don't seem to know about a shortcut that combines five other actions.
Etc, etc.
Telemetry doesn't bring anything more to the table. When I see an app with telemtry, I am just thinking they don't know what they are doing.
Here is an example: https://github.com/Microsoft/vscode/issues/707
Bold move, Cotton.
Most of analytics data never gets looked at and never provides any useful insight because it's setup poorly.
Whether you should care comes down to your ideology. My view: I totally see the value in tracking your users, but I also believe there should always be an option to opt out. Tracking becomes insidious when you lose the right to not participate.
By choosing to opt out, you're showing Microsoft that there are people that genuinely care about being able to not be tracked, making it more likely for them to keep this option for the future.
How is Microsoft supposed to know you disabled telemetry? VSCode can't tell them you did, that would be a form of telemetry :P