News for hackers. Stuff that matters.
Re:Show HN: GitPlex – A new Git repo management server with ... by skrebbel on Wednesday November 23, 2016 @06:09AM (#13021692)
Folks, this is why you want to do code reviews inside your editors / IDEs. I like this project, but really what they did is build a read-only version of an IDE from the ground up. You already have one and you know it inside out.

I've found, as the OP did, that the GitHub/Lab/Bucket code review UIs strongly encourage nitpicking over code style and strongly discourage true insightful reviews on a design and architecture level. This happens simply because of the amount of effort your have to do to see and feel the wider impact of a pull request on your codebase. It's like looking at code with blinders on.

So what you want to do is checkout the pull request and use your editor. We made this a habit here at TalkJS and the quality, speed and usefulness of our code reviews skyrocketed.

Actually we take it one step further: we dropped the commenting interface altogether. Our code reviews are commits, with code comments by a particular format:

    // REVIEW(marcin<-egbert): Won't the event listener get re-registered every time this function is called?
My colleague Marcin can find all reviews intended for him by grepping for `REVIEW(marcin`. Git ensures that even across merges and code changes, comments stay put, and once Marcin applies the review comment he removes the comment. He can reply by adding a comment in the same format.

The fact that review comments are right there in the git history also really helps track down complicated problems. Finally, we get the freedom of merging a PR anyway even though some things ought to be better, without losing track of the review comment. Obviously that's a code smell, but sometimes it's better to release first and refactor next day.

But even if you think this is insane and reviews don't belong in the code, I'd like to warmly encourage you to use your editor for reviews.

Re:Show HN: GitPlex – A new Git repo management server with ... by notheguyouthink on Wednesday November 23, 2016 @09:31AM (#13022856)
I'm still seeking a good way to do reviews/merges with Vim though. I use a Macpro Ret 13" and it nicely fits two ~80char windows. However, three windows as vim normally does for merge conflicts/etc is too much for the 13" screen, it ends up cluttered and cramped.

Anyone have any recommendations for how to efficiently handle conflicts/reviews via vim with a small screen?

Re:Show HN: GitPlex – A new Git repo management server with ... by houzi on Thursday November 24, 2016 @11:40AM (#13031199)
I am surprised that your highres screen doesn't handle three buffers side by side. My 13" 720p laptop also has trouble with three buffers, but I was hoping that would be mitigated the day I got a highres 13" laptop.

Anyways, you can try a narrow width font: I love M+ 1mn, though the narrow width causes problems when it doesn't have a certain unicode point defined and falls back to a full width font..

Re:Show HN: GitPlex – A new Git repo management server with ... by notheguyouthink on Thursday November 24, 2016 @01:43PM (#13031994)
Yea, it's likely a font issue. This[1] is what my font looks like, which is quite readable to me but i can't get much smaller (for me personally). Each pane fits ~85 chars (not including the vim sidebars/etc), so it's quite perfect for two panels.

Note that OSX by default has some type of feature that reduces the realestate you have available.. don't ask me to explain it, i haven't really used it much.

Basically, with the Retina monitors, the resolution is actually too high for a lot of scenarios. You end up with tiny fonts, tiny icons, etc. So they somehow sample/zoom the sizes so that you get both really crisp renders but with very few real pixels on screen.

This may be what is causing you to be surprised that i am still having issues with a high resolution Retina screen. But, turning it off would be effectively the same thing as just turning my iTerm2 fontsize to ~8-10 or something tiny, allowing me to fit three panes.

[1]: http://imgur.com/MBvoEJd

Re:Show HN: GitPlex – A new Git repo management server with ... by ibizaman on Friday November 25, 2016 @01:56AM (#13034800)
Well I simply don't use the three way view. I find it easier to read when only having one window with the file having the <<< and >>> lines. As an aside, I also use the fugitive plugin and the promiscuous one which makes the whole process easier.
Re:Show HN: GitPlex – A new Git repo management server with ... by robinshen on Wednesday November 23, 2016 @07:17AM (#13022020)
Thanks for the ideas. While I agree with you that desktop IDE is a good place for design and architecture level reviews, having a lightweight web "IDE" will be beneficial as it does not require you to switch your local workspace to particular revisions for review.

Also I often find myself need to copy code from some old revisions, in that case, I just visit our web "IDE", find desired revisions with revision search helper, and open desired symbols to copy relevant code out.

Re:Show HN: GitPlex – A new Git repo management server with ... by 91bananas on Wednesday November 23, 2016 @08:47AM (#13022579)
A really good editor will allow you to do this without leaving. Pycharm/jetbrains handle this the best I have ever seen. Atom is almost there with a couple of the packages I have found
Re:Show HN: GitPlex – A new Git repo management server with ... by andruby on Thursday November 24, 2016 @04:52AM (#13029384)
Which Atom packages did you find to help you with this?
Re:Show HN: GitPlex – A new Git repo management server with ... by 91bananas on Friday November 25, 2016 @11:38AM (#13037874)
[email protected] [email protected] [email protected] [email protected]

are the main ones, git-time-machine is probably my favorite package period in the Atom ecosystem. As it shows what is possible with completely user created UI.

Shameless plug for a package I wrote too https://atom.io/packages/atom-git-revert which also helps on the daily!