I'm also of the opinion that if you are learning music to become a star, you aren't learning for the right reasons. If you become good enough to make money at it, that's awesome, but I don't know many musicians that do earn any money.
I don't practice often but as an adult I have a little disposable income to pay for a couple of guitars and an amp. I even picked up a cheap travel electric guitar with a built-in amp/speaker which is honestly awesome for noodling around over top of someone playing acoustic around a campfire or some such.
Not really trying to make any point I guess. I had vague dreams of fame and fortune but found that over time, it was still pretty rewarding to be able to play something even if I don't give it as much of my time as I might. It's a creative outlet, it can be a way to relax, and you know...occasionally, girls still dig it :)
Guitar is a cross-over instrument in the sense that it can be used for rock, jazz, blues as well as classical. It's supported by a wide selection of composed music for all. Although electric guitar and classical guitar are not the same, learning one of them gives a huge amount of resources to learn the other.