News for hackers. Stuff that matters.
Re:What is “:-!!” in C code? by Mindless2112 on Monday November 21, 2016 @01:16AM (#13003541)
That code seems needlessly arcane. You can get the same results without resorting to anonymous bitfields:

  #define BUILD_BUG_ON_ZERO(e) (sizeof(char[(e) ? -1 : 0]))
which, when it fails, results in

  error: size of unnamed array is negative
which is no worse than the provided code which results in

  error: negative width in bit-field '<anonymous>'
It's worth noting that declaring an array with 0 elements is not allowed in C99. However, using a struct with no named members has undefined behavior in C99 [1].

[1] http://stackoverflow.com/a/12918937/959866

Edit: You can get around having 0 elements by using

  #define BUILD_BUG_ON_ZERO(e) (sizeof(char[(e) ? -1 : 1]) - 1)
but you're starting to lose clarity again.
Re:What is “:-!!” in C code? by peterdn on Monday November 21, 2016 @01:52AM (#13003671)
In some compilers due to C99 variable length arrays [1], your macro compiles happily if passed a value that is not a compile-time constant.

For example, this compiles but segfaults at runtime (GCC 4.9.2):

  int main(int argc, char * argv[]) {
    return (sizeof(char[(argc) ? -1 : 1]) - 1);
  }
[1] https://gcc.gnu.org/onlinedocs/gcc/Variable-Length.html
Re:What is “:-!!” in C code? by Mindless2112 on Monday November 21, 2016 @02:04AM (#13003722)
Ah, good point. One more reason for me to hate VLAs. ;)

The negative-length array trick is used in the Linux kernel source code [1]. I expect it's compiled with -Wvla though.

[1] https://github.com/torvalds/linux/blob/v4.5/arch/x86/boot/bo...

Re:What is “:-!!” in C code? by Sacho on Monday November 21, 2016 @02:23AM (#13003775)
Looks exactly like the macro Jan Beulich replaced with the one discussed in OP: https://github.com/torvalds/linux/commit/8c87df457cb58fe75b9...
Re:What is “:-!!” in C code? by pjmlp on Monday November 21, 2016 @04:53AM (#13004257)
They are so good that they became optional in C11[0] and thankfully were not adopted by ANSI C++.

[0] - ISO 9899:2011 Programming Languages - C 6.7.6.2 4

Re:What is “:-!!” in C code? by thomasahle on Monday November 21, 2016 @05:56AM (#13004489)

    -#define BUILD_BUG_ON_ZERO(e) (sizeof(char[1 - 2 * !!(e)]) - 1)
    +#define BUILD_BUG_ON_ZERO(e) (sizeof(struct { int:-!!(e); }))
    +#define BUILD_BUG_ON_NULL(e) ((void *)sizeof(struct { int:-!!(e); }))
The commit that introduced the notation, actually used something similar to your second approach: https://github.com/torvalds/linux/commit/8c87df457cb58fe75b9...