Re:Show HN: Whosfiring
by gsnedders on Tuesday November 15, 2016 @09:11AM
(#12958080)
All major screenreaders work from the DOM and the accessibility tree nowadays, and have done for a long time at this point. Dynamic content is no problem in and of itself.
[ Parent
| on HN ]
Unless you are fetching data async. Google and other will not wait for data.
Re:Show HN: Whosfiring
by Steppschuh on Tuesday November 15, 2016 @12:06PM
(#12959908)
That's not true. Google indeed waits for async content to load for a given amount of time. You can inspect this from the Google webmaster tools.
I did a lot of tests on this and Google just didn't wait, no matter the configuration. I tested using webmaster tools. The App was built using React, and I ended up implementing SSR to fix the problem. There are a lot of posts that hack this embedding JSON directly on the page. I didn't find any post that figured out a way to make this works through async API requests. I would thank you if you point one in that direction. Maybe I'm doing something wrong.
Were you using react-router by any chance?
I've bookmarked this site: "Testing a React-driven website’s SEO using “Fetch as Google" https://medium.freecodecamp.com/using-fetch-as-google-for-se...
That talks about this. Not had a chance to verify this. just a fyi.
Interesting, never occurred to me that react-router could be the problem, I will investigate that. But this other post [1] didn't use React at all and made API requests to GitHub with the same problem.