Yep.
The best piece of career advice I ever got was to work in departments that are profit centers, not cost centers.
I've seen the dynamic play out several times: the employees in the profit centers are treated well, and the employees in the cost centers frequently need to justify the existence of their department and their jobs when management decides to cut costs. It's pretty clear who has the better job security and job satisfaction.
That's not a given, and I agree with braythwayt above that assessing the company's commitment is the most important consideration, but there are strategic reasons they could prioritize it.
Here's the business reality: On the balance sheet for the abuse team, there are only expenditures. The benefits don't show up on the balance sheet there; there are diffuse, spread throughout the company, and often future-biased (the abuse shut down today may prevent people from leaving next month). It's the same for IT at a bank, customer support staff anywhere, or accountants. No matter how important it may be, it's not revenue generating. And that makes a huge difference in future career prospects. Things that may impact revenue in a year is not important to a company becoming concerned it may not make it to that year.
(In Twitter's case, while there will probably be a business entity called Twitter in a year, the thing that might not make it to next year is Twitter-the-unicorn-dream. Going into maintenance mode or being acquired at unfavorable terms, while better than going out of business entirely, is still a failure for the Twitter of today.)
I say this as someone who is not really directly revenue generating myself; I'm moving ever more into risk mitigation and management. But the company I'm doing it in is not currently contracting and laying off, but growing. I've got my eye on my own situation, too.
Not disagreeing with the point that being employed in a cost center of a struggling company has risk. You always would prefer to be at the competitive edge if you can, and in a role that aligns with the company's main mission. I just suspect that in this case, the recent abandonment of Twitter buyout offers due to the abuse problem has now made curtailing abuse a top priority, and a much more important part of the company's ability to deliver value.
Another example would be a company whistling past the graveyard with respect to security, seeing security as a non-revenue-generating cost center. All it takes to wake up the board to its importance is a major breach that affects the market cap. (Or take quality control in companies that deal with life-and-death systems.)
But yeah, it's still definitely a risk. As a long-time startup person, I'm more practiced than most at dealing with financial risk, but I appreciate you mentioning it.
Basically, if you read the end of 1984 and always wished your boot could be the one stomping on a human face forever - especially if it was a black woman's face - then this could be the career for you. Otherwise, run away.
The temptation is probably to try to rationalize how obviously important it is, but that's true of everything in the business so it carries no weight. It's not revenue generating. You don't need to convince me it's revenue generating, you need to convince management, who will be looking at a revenue sheet at the time and seeing negative numbers from that department. It may be shortsighted but companies looking at significant chances of failure in the short term get shortsighted. They have to.
That said, as you suggest, the worst case scenario is that you join and then you lose the job, and then you're back to not having a job. If you can tolerate that financially, then it may still be a good risk. But please be sure you can tolerate that financially.