In which case you've lost nothing since that money wouldve been in a conventional account and taxed to hell anyways.

Put it in the IRA and if things don't go to shit, your money is fine. Don't put it in the IRA and of things go to shit, lose the tax advantage.

Do either and things go to shit, it doesn't matter which you did.

No, that money would have been in a 401k, so you would lose out on the initial benefit of not having paid taxes when you contributed if they raid Roths.

But, if you've already maxed out your other tax-advantaged space, and you have more money to contribute, there is no reason not to put it in a Roth instead of a regular taxable account, assuming you are eligible, because then you can have tax-free growth at least(worth less than tax-free contributions, but still worth a lot).

In the same scenario that Roth IRAs are at risk of extra taxation (or fees), 401(k)s are as well. That doomsday scenario isn't worth planning for with money, but with physical assets (property, food, tools) and skills because that's the scenario where the US economy collapses (not a recoverable crash like 1929 or 2008, but a true, complete collapse where the USD value goes to zero).

Roth IRAs make sense if you make too much to contribute to a Traditional IRA with tax advantaged contributions and little enough to still qualify for the Roth.

They also (both traditional and roth) have an advantage over a 401(k): You get to manage the funds any way you want. You also get to contribute even when your employer doesn't have one, you just need income (capital gains don't count, as I understand it, so being semi-retired and living off your earnings does preclude you from contributing).

You're also limited on 401(k) investments to whatever your employer contracted for. Could be shitty, could be stellar, you don't control it.

That's what I try to be mindful of regarding Roth. How strong is the promise that it won't be taxed? Or maybe it isn't taxed, but new fees are introduced as a roundabout tax.

Like a lot of retirement thinking, it's unsettling to think about the negative scenarios.

I think it is unlikely, but the chance that they will tax Roth withdrawals is positively correlated with the very scenario that makes contributing to them advantageous, a massive tax hike in the future. If the government needs money that badly, everything is potentially on the table, down to a flat haircut tax on bank balances.