Ecological Benefits: "Once known as the “California Riviera”, the Salton Sea is now called one of America’s worst ecological disasters: a fetid, stagnant, salty lake, that coughs up dead fish and birds by the thousands in frequent die-offs that occur."
[1] https://en.wikipedia.org/wiki/Plagues_%26_Pleasures_on_the_S...
But you're talking about the technical debt of the Salton project. It was pretty great at first and we were adding a new species every week. But eventually, support for the project was diverted and it dried up. Now the whole thing reeks of code smell and everybody knows we need to fix the thing -- but it's in a remote area so it's hard to convince management that the project is worth the resources to save.
Perhaps support was diverted simply because the benefits simply weren't going to outweigh the costs... ever.
It would be "spectacular and peaceful." It would "materially alter the climate in adjacent areas." It would "provide work during construction and living areas after completion for the Palestinian Arabs." It would get Egyptian president Gamel Abdel Nasser's "mind on other matters" because "he need[ed] some way to get off the Soviet Hook.""
Hmm, maybe that could be a way to offset flooding from climate change, by redistributing the water elsewhere into low-lying but dry land.
I see it as a reallocation of electricity to a different neighborhood, reduction of water to current cities, creation of new cities along the route of diversion, and unpredictable ecological impacts.
But on the bright side, I predict the constant evaporation would reduce over time with the establishment of cities and possibly air polluting factories, whose constant smog would crystalize the evaporated water into immediate rain.
Now that would probably have consequences for the Nile Delta, particularly in terms of saltwater intrusion... but the the Nile Delta is already somewhat screwed this way.[1] But I'm a meteorologist and not a hydrologist, so don't take my word on it.
What I can say is that large bodies of water moderate temperature around them and create wildlife habitat, as North African lakes apparently did during the Pleistocene. The ecological impacts might be unpredictable, but they're definitely not unprecedented.
Also when you say "reduction of water to current cities", you sound a lot like people here in the U.S. who think they will get less Colorado River water if it's stored in Lake Mead than if it was in Lake Powell. That's not how politics works; and storing the water in two dams only increases evaporation so everyone gets less water :(
I'd prefer the Nile variant, which would be hard to do for sure. But like the Salton Sea, flooding parts of the desert seems to have ecological benefits.