Re:A Soccer Con Man Who Couldn't Play the Game
by MaulingMonkey on Tuesday August 23, 2016 @04:25AM
(#12342189)
To be fair, I'd reroll atoi too - but only once, with "sufficient" unit tests (e.g. round trip unit tests for INT_MIN..INT_MAX), and only because atoi has no proper error checking nor wchar_t* variants.
[ Parent
| on HN ]
Re:A Soccer Con Man Who Couldn't Play the Game
by kazinator on Tuesday August 23, 2016 @06:32PM
(#12348312)
Indeed; atoi in fact invokes undefined behavior in out of range situations; you can only safely use it when the input has been lexically analyzed to be a valid integer of only so many digits as not to overflow.
I'd tend to make this re-rolled atoi a wrapper around strtol/wcstol.
Re:A Soccer Con Man Who Couldn't Play the Game
by MaulingMonkey on Wednesday August 24, 2016 @02:26AM
(#12350117)
> atoi in fact invokes undefined behavior in out of range situations
Ouch! TIL. You'd think by now I wouldn't be surprised by such things, and yet, somehow I was...