CryEngine out on GitHub

Re:CryEngine out on GitHub by webkike on Tuesday May 24, 2016 @11:59AM (#11762606)

This code is not actually that _complex_, it is just _complicated_, and there are probably several people within the company that understand it completely. If you actually go through the code, I bet you will understand the majority of it. Step functions are annoying and complicated and need to be _fast_, less than half a frame long. And you need to do a lot in them, and all of those things are tightly coupled.

[ Parent | on HN ]

Re:CryEngine out on GitHub by damptowel on Tuesday May 24, 2016 @06:41PM (#11766144)

another such beauty

http://hg.icculus.org/icculus/lugaru/file/97b303e79826/Sourc...

[ Parent | on HN ]

Re:CryEngine out on GitHub by zubspace on Wednesday May 25, 2016 @05:44AM (#11768654)

Wow.

Question regarding index access: There are tons of for loops with player[k] occurrences and similar. Personally I would create a local variable and prevent further index-retrievals.

Is this worthwhile or would a compiler optimize the array-index access away? Or maybe subsequent uses of the same index are cached by the cpu? Does someone know?

[ Parent | on HN ]

Re:CryEngine out on GitHub by tehrei on Wednesday May 25, 2016 @09:54AM (#11769747)

That's a micro-optimisation that's absolutely worthless. Even if you do pay the cost of indexing an array every single time, that's just a single instruction to fetch the address. The compiler is absolutely capable of caching the indexing for you, either in a register or on the stack, if it deems it worthwhile.

One reason you might want to use a separate variable would be to prevent indexing mistakes, like using i instead of k by mistake in a context where i is a nested loop's counter. But apart from this and other "to make it easier on the human" reasons, there's no point in caching that in a variable. Now, if you were writing Python on the other hand...

[ Parent | on HN ]

Re:CryEngine out on GitHub by ensiferum on Wednesday May 25, 2016 @06:38AM (#11768826)

Holy batman. Now this is officially the worst piece of code I've ever seen in my 15 years of programming. This has to be generated... right?? I can't believe any human wrote this.

Grabs the eye bleach

[ Parent | on HN ]

Re:CryEngine out on GitHub by webkike on Wednesday May 25, 2016 @11:37AM (#11770513)

It was written by a highschooler who made a 3D video game with decent physics and you're... criticizing him? Man, I'd like to see what YOU wrote in highschool.

[ Parent | on HN ]

Re:CryEngine out on GitHub by PeCaN on Tuesday May 24, 2016 @08:40PM (#11766800)

On top of that, in a step function you really want to see what's being modified (that's kinda the point...). I suspect that monstrosity is easier to maintain than having state updates scattered around and having to jump to definitions and back to step() to understand the thing.

[ Parent | on HN ]