News for hackers. Stuff that matters.
Re:Viber adds end-to-end encryption by tptacek on Tuesday April 19, 2016 @11:13AM (#11527532)
WhatsApp's "E2E" code is from Signal, which is open source.

This zealous belief that all secure cryptography must be open source is something I hear a lot from open source advocates, but not so much from cryptography engineers.

Re:Viber adds end-to-end encryption by arbsn on Tuesday April 19, 2016 @11:27AM (#11527622)
Is the encryption/decryption code in WhatsApp open-source? I haven't been able to find it. My assumption was that they conform to the Signal encryption protocol, which is openly specified, but that the code they use to do so is not open-source.
Re:Viber adds end-to-end encryption by moxie on Tuesday April 19, 2016 @12:56PM (#11528309)
Yes, it is. It's linked directly from the paper (https://www.whatsapp.com/security/WhatsApp-Security-Whitepap...) that documents their use of the protocol.

It's the exact same code we use in Signal: https://github.com/whispersystems/libsignal-protocol-java

Re:Viber adds end-to-end encryption by AJ007 on Tuesday April 19, 2016 @01:25PM (#11528560)
The value is not just the public display of the source code for auditing, but the validation that what you are running was indeed compiled from that code.
Re:Viber adds end-to-end encryption by brianacton on Tuesday April 19, 2016 @08:30PM (#11531539)
This is literally an impossibility. Java apps are typically obfuscated with randomization of symbol names. Each build is unique and not reproducible.

You are better off verifying the actual compiled and distributed apk files than verifying the source.

Re:Viber adds end-to-end encryption by danjoc on Tuesday April 19, 2016 @09:49PM (#11531785)
Re:Viber adds end-to-end encryption by russell_h on Tuesday April 19, 2016 @02:45PM (#11529188)
Simply open sourcing the code doesn't give that validation.
Re:Viber adds end-to-end encryption by AckSyn on Tuesday April 19, 2016 @06:28PM (#11530993)
Not completely but I can certainly look at it, compile, and then side-load it onto my device knowing it's what it said it was.
Re:Viber adds end-to-end encryption by danjoc on Tuesday April 19, 2016 @01:35PM (#11528637)
You keep saying this, but how do we know they are actually using the code from Signal without access to source and reproducible builds? Last time you told me it was easy and legal to reverse engineer the code. I then asked you what tools you use to do that and you ignored the question.
Re:Viber adds end-to-end encryption by tptacek on Tuesday April 19, 2016 @02:03PM (#11528851)
To reverse engineer code? For big projects, I used IDA, like everyone else does. For smaller projects, I used Hopper, or, for architectures that IDA and Hopper didn't support, I'd postprocess binutils output.

For an example of a more sophisticated approach, look at:

https://sourcedna.com/

Remember, in this case, it's especially easy to reverse, because you have the source code; all you're doing is matching the control flow graph to the original source.

Re:Viber adds end-to-end encryption by danjoc on Tuesday April 19, 2016 @10:08PM (#11531826)
Thanks for making this response. Genuinely interested.

[To whomever down voted... I guess I get down voted for not showing gratitude immediately after he posted a reply? This is why I don't post here often. Quite mean people here.]

Re:Viber adds end-to-end encryption by nialo on Tuesday April 19, 2016 @03:22PM (#11529457)
Do you know if there exist tools that take a binary and a source code file and attempt to automatically compare the control flow graphs?

I imagine I won't ever get to it, but that sounds like an interesting problem to try to work on.

Re:Viber adds end-to-end encryption by tptacek on Tuesday April 19, 2016 @03:37PM (#11529559)
Yes, there are. SourceDNA does a bunch of this.
Re:Viber adds end-to-end encryption by moxie on Tuesday April 19, 2016 @02:12PM (#11528925)
If you want to look at the Android APK, you can use apktool to get back Java source. Hacked clients like WhatsApp+ even build new derivative products using that output, and spammers do it to get code they can use to inject messages onto the network without having to write their own software.

I think it's great when people further verify WhatsApp's client security, please share your analysis!

Re:Viber adds end-to-end encryption by danjoc on Tuesday April 19, 2016 @10:14PM (#11531840)
Thank you for your tip and contributions to open signal. I appreciate that you want to get encryption into as many hands as possible, even if circumstances may not be ideal.

My primary concern here is a long con. Everything is probably okay now, but after a while, people will stop looking and verifying. With WhatsApp keeping source closed, it makes that period of time shorter, I think. I will try to work your suggestion into my job :) If I'm paid to do it, I can keep doing it indefinitely, even working on tools to automate it.