Re:Bluebird in the wild: Advanced promise-based workflows
by hiphipjorge on Tuesday April 19, 2016 @10:26AM
(#11527176)
Thanks diego! Yes, you're totally right. That line is not needed. I'll go in and fix it. But because of how `promisifyAll` works the code would still work the same way :)
Re:Bluebird in the wild: Advanced promise-based workflows
by untog on Tuesday April 19, 2016 @01:36PM
(#11528647)
One thing I was surprised to discover is that promisifyAll alters the original object - which is actually great for ES6 imports. So:
import fs from 'fs';
Promise.promisifyAll(fs);
works great.
Re:Bluebird in the wild: Advanced promise-based workflows
by altano on Tuesday April 19, 2016 @02:15PM
(#11528947)
That probably won't work when you switch from Babel=>ES5 to Babel=>ES6 (http://www.2ality.com/2015/07/es6-module-exports.html?m=1) as ES6 bindings are immutable bindings to the actual values in the module instead of copies.
Re:Bluebird in the wild: Advanced promise-based workflows
by romanovcode on Tuesday April 19, 2016 @05:33PM
(#11530639)
There is nothing wrong in using callbacks. I actually see many developers over-use promises to the point where code is nearly unreadable.
The before code should not have Promise: "const fs = Promise.promisifyAll(require('fs'))"