News for hackers. Stuff that matters.
Re:String types in Rust by pcwalton on Monday March 28, 2016 @05:15PM (#11377457)
Three reasons why Rust cannot adopt Go's solution:

1. Rust is not garbage collected. This means that a separation between strings-that-own-their-data and strings-that-reference-their-data is needed.

2. Rust cares about first-class FFI support; in particular, copying strings at FFI boundaries is right out. That is why Rust needs C strings to be a separate type.

3. Rust wants to do pathnames right in a cross-platform way. In particular, it should be impossible for other apps to create valid pathnames that cause Rust apps manipulating those paths to crash or malfunction. UTF-8 paths fail this criterion.

Re:String types in Rust by p0nce on Tuesday March 29, 2016 @06:16AM (#11380512)
> Rust cares about first-class FFI support; in particular, copying strings at FFI boundaries is right out. That is why Rust needs C strings to be a separate type.

How does Rust handle strings encoded as UTF-16 or UTF-32? Does it need immediate conversion?

Re:String types in Rust by fpoling on Tuesday March 29, 2016 @07:04AM (#11380649)
OsString [1] in Rust provides native string that can be directly passed to OS-specific API. It is UTF-16 on Windows.

[1] - https://doc.rust-lang.org/std/ffi/struct.OsString.html

Re:String types in Rust by PopsiclePete on Monday March 28, 2016 @06:48PM (#11378093)
Point 3 reminds me of Haskell trying to prove certain grammars correct at compile-time or C++ calculating factorials using template meta-programming.

Very cool to show off to your geek programmer friends and impress them, but I really question the day-to-day usefulness when considering the added complexity.

I have never ever had bugs in my code from somehow having invalid Unicode code-points in my paths. 99% of the time, replacing '/' with '\' and handling drive letters gets you there. I realize certain classes of bugs could happen, but I'd rather take that risk, have a bug, and fix it, than burden the type system and libraries.

In a way, I'm a little sad that modern computer languages are going from C's extreme of "always trust the programmer" to the other of "never trust the programmer". Bugs are bad, but language usability, ease-of-use and simplicity are also worth fighting for.

Having said all that, I am really happy to see Rust being awesome in the general case and appreciate all the work you and the rest of the team are putting forth.

Re:String types in Rust by pcwalton on Monday March 28, 2016 @07:42PM (#11378413)
> Point 3 reminds me of Haskell trying to prove certain grammars correct at compile-time or C++ calculating factorials using template meta-programming.

They don't seem analogous in the slightest. Grammars can be correct without being proven correct. Calculating factorials at runtime instead of at compile time doesn't change the result of the calculation. But treating all paths as though they were UTF-8 breaks programs when certain paths are fed to them.

> I have never ever had bugs in my code from somehow having invalid Unicode code-points in my paths. 99% of the time, replacing '/' with '\' and handling drive letters gets you there. I realize certain classes of bugs could happen, but I'd rather take that risk, have a bug, and fix it, than burden the type system and libraries.

So this philosophy is what brought us the fun of feeding paths that contain spaces to shell scripts. Except this would be worse, because you can write space-correct Bash scripts—but if paths in the language are UTF-8, and you have to work with a path that contains non-UTF-8 characters, there is literally nothing you can do, and your program will be broken no matter what†. I'm glad that Rust took the time to do things right and figured out how to make the right thing ergonomic instead of giving up, deciding that correct paths are impossible, and forcing everyone to write broken programs.

By the way, this is not a theoretical problem: VCS's have been bitten by this in the real world. https://www.redmine.org/issues/2664

† Note that Golang has a different solution to this problem: strings in Golang don't have to be UTF-8, and they're only UTF-8 by convention. This is a totally valid solution, but Rust didn't go with it because removing the invariant that strings are UTF-8 has downstream consequences that affect every API that takes strings.

Re:String types in Rust by vessenes on Monday March 28, 2016 @07:02PM (#11378167)
> 99% of the time, replacing '/' with '\' and handling drive letters gets you there.

I think that's precisely the point; at scale, and with today's modular software culture (like last week's left-pad news cycle demonstrates), 99% correct software can mean millions of installations of bad code, all vulnerable to attack, or even just 1%-type bugs.

One way to think about the last 10 years of language design is an ongoing dialogue on how much or little to trust engineer intuition about which tools are safe for which jobs. The pendulum is swinging towards the belief that in general engineers should be given much more safety-oriented tools.

Re:String types in Rust by catnaroek on Monday March 28, 2016 @10:28PM (#11379108)
It's not like we embrace complexity for its own sake. The harsh reality is that things like file paths, dates and times, phone numbers and even people's names are already intrinsically complex; and you can either acknowledge this complexity in your code, or ignore it at your own peril. If you want to blame anyone anyone for the complexity, blame those who design file systems, or ISO-standardize date and time formats, or even humanity as a whole for coming up with all sorts of naming customs! A programmer (or any other given single person) has only so much control over the complexity of their environment.

Also, you seem to think typeful programming is just for those who either want to show off (“to your geek programmer friends”) or don't trust other programmers (“to the other [extreme] of "never trust the programmer"”). This plainly untrue. Typeful programming is for those who embrace code as a communication medium (“my data structure has these complex invariants, which I can communicate either with three lines of code, or with two long English paragraphs in comments than might even get out of sync”) and want to include the type checker in the conversation (“this code is rather tricky, and I made lots of changes to it, could you check for me if I missed anything?”). Of course, the effectiveness of code as a communication medium is contingent on your ability to understand code.

Re:String types in Rust by bjz_ on Tuesday March 29, 2016 @03:39AM (#11380065)
Exactly. The complexity is inherent in the domain, and making it seem simpler by sweeping it under the carpet is not solving the problem, and it will result in hard to find bugs when working at scale.
Re:String types in Rust by dllthomas on Tuesday March 29, 2016 @01:14PM (#11383000)
There's abstraction, leaky abstraction, and brokenness.

Making things seem simpler by finding an abstraction over them is great!

Making things seem simpler by finding an abstraction that leaks some details so you sometimes need to handle them at a high level is... less great. But sometimes still a win.

Making things seem simpler but neither handling the complexity nor allowing your users to handle the complexity is technical debt at best.

Re:String types in Rust by catnaroek on Tuesday March 29, 2016 @02:21PM (#11383626)
Maybe this is just a sign of my lack of experience, but I don't think implementing leaky abstractions is ever justified outside of systems programming. (Implementing a runtime system for a manged language counts as “systems programming” in my book.) Here are some examples of justified leaky abstractions:

(0) Memory is infinite, and memory allocation will always succeed. If it doesn't, aborting the entire process is the right course of action.

(1) Communication over a network is reliable and data will arrive in the same order in which it was sent.

And here are some examples of unacceptably leaky abstractions:

(0) A few basic data structures [in particular, growable arrays and hashtables] suffice to implement every algorithm you might ever want to implement.

(1) Strings are arrays of characters, and thus you can efficiently index them by character.

(2) Every [nonempty] string is a valid file name or URL.

(3) Every external resource can be manipulated using an API that presents it as a sequence of bytes.

(4) An event loop is the universal solution to all asynchronous I/O problems.

Re:String types in Rust by dllthomas on Tuesday March 29, 2016 @03:52PM (#11384355)
I don't see how your examples line with "systems programming" vs "not systems programming".

I think in general, building on top of leaky abstractions is a form of technical debt, and you have to be aware of how much you're accumulating and what you're getting in exchange. Also, complexities stack super-linearly. I'm tempted to say, additionally, that building shallowly atop a leaky abstraction is less problematic than pushing leaks further down in a tall stack... but on reflection I have no idea how I'd support that.

Re:String types in Rust by catnaroek on Tuesday March 29, 2016 @04:53PM (#11384780)
Building on top of leaky abstractions isn't necessarily a form of technical debt. Some leaky abstractions are actually better than their non-leaky counterparts. For example, not worrying about the possibility of running out of memory lets you concentrate on whatever your program is actually supposed to do, rather than micromanaging a very improbable situation.

So, what I meant to say in my previous post is that, as far as I can tell, good leaky abstractions only arise when doing systems programming, or, more precisely, at the boundary between low-level system services (e.g. runtime systems for managed languages) and the applications that consume them. Abstraction leaks in high-level application code are likely to be bad.

Re:String types in Rust by dllthomas on Tuesday March 29, 2016 @06:23PM (#11385426)
Hmm. I think that's a little confused.

You need to worry about running out of memory precisely because the abstraction is leaky. If you need to micromanage, it's perhaps not leaky, but it's also not much of an abstraction.

Exploring this example a little deeper, if our model is "we never run out of memory, but our program may stochastically die at any point in time", then that's not as leaky as "we never run out of memory", and our program may die for reasons outside our control so it's a good idea to be robust against those. But now let's say we need to send a request to a service, and the service disconnects when we've sent the request. With a stochastic model of failures, we clearly should just re-send. But if the problem was that our payload demanded more memory than could be provided, retrying repeatedly will just keep killing servers.

We probably want a model of "we never run out of memory, our program may die at any point in time, possibly correlated with inputs", which I would contend is actually not very leaky. We still spill over into performance, but most things spill over into performance...

I would say that leaky abstractions constitute debt relative to non-leaky equivalently powerful abstractions. They may still pay their way.

Re:String types in Rust by catnaroek on Tuesday March 29, 2016 @07:10PM (#11385715)
> You need to worry about running out of memory precisely because the abstraction is leaky.

In practice, I don't worry. I'm fine with the leaky abstraction, because the benefit of fixing the leak (reducing the probability that OOM crashes my program from almost zero to exactly zero) isn't worth the cost (increased complexity). But see below.

> If you need to micromanage, it's perhaps not leaky, but it's also not much of an abstraction.

I'm not sure about this. There are levels of abstraction and degrees of micromanagement. For instance, `malloc` lets you micromanage the memory layout of your data structures, and `mmap` and `mprotect` also let you micromanage what you can do with each memory page, but they're still abstractions over even lower-level concerns, like the mapping between physical and virtual memory addresses.

> We probably want a model of "we never run out of memory, our program may die at any point in time, possibly correlated with inputs", which I would contend is actually not very leaky.

Depends on what kind of program you're writing. If your web crawler crashes, you just restart it. If your web server crashes, your users will be annoyed, but at least your database won't be compromised. (You're properly using transactions, right?) But if your DBMS crashes, your data might even be in an irrecoverably inconsistent state, unless you properly anticipated all (software) causes for it to crash.

Re:String types in Rust by dllthomas on Tuesday March 29, 2016 @07:21PM (#11385776)
> In practice, I don't worry. I'm fine with the leaky abstraction, because the benefit of fixing the leak (reducing the probability that OOM crashes my program from almost zero to exactly zero) isn't worth the cost (increased complexity).

In practice, you're being sloppy or what you've described is the relevant worrying - considering whether your program has appreciable odds of OOM and the odds of things being particularly bad when that happens, and then deciding that additional worrying is unnecessary. But this can need re-evaluating as circumstances change.

> There are levels of abstraction and degrees of micromanagement.

No disagreement there.

> Depends on what kind of program you're writing.

A bit, but mostly in terms of performance.

> But if your DBMS crashes, your data might even be in an irrecoverably inconsistent state, unless you properly anticipated all (software) causes for it to crash.

I disagree. If you have designed your program with an assumption that it might fail at any point regardless of reason, then you don't need to have "properly anticipated all (software) causes for it to crash", and further you should be robust against some portion of non-software causes.

Re:String types in Rust by catnaroek on Tuesday March 29, 2016 @07:55PM (#11385938)
> In practice, you're being sloppy or what you've described is the relevant worrying

I'm unhappy with this line of reasoning. For me, an abstraction leak is a failure to behave as advertised. Since memory allocation can always fail, an abstraction that advertises “allocations always succeed” is necessarily leaky. Even if the leak isn't important in practice, the leak exists.

> If you have designed your program with an assumption that it might fail at any point regardless of reason

I'm not sure this is even possible (if I take nothing for granted, how do I do anything?), but I'd like to be proven wrong.

Re:String types in Rust by dllthomas on Tuesday March 29, 2016 @09:53PM (#11386420)
> I'm unhappy with this line of reasoning. For me, an abstraction leak is a failure to behave as advertised.

To my mind, it must fail to behave as advertised in a way that is meaningful. Otherwise, the differences are precisely what is being abstracted away.

> I'm not sure this is even possible (if I take nothing for granted, how do I do anything?), but I'd like to be proven wrong.

I don't mean "might act in arbitrary ways", but specifically "might be unexpectedly be terminated at any point".

Re:String types in Rust by sgift on Tuesday March 29, 2016 @01:30AM (#11379653)
> I have never ever had bugs in my code from somehow having invalid Unicode code-points in my paths. 99% of the time, replacing '/' with '\' and handling drive letters gets you there. I realize certain classes of bugs could happen, but I'd rather take that risk, have a bug, and fix it, than burden the type system and libraries.

Lucky for you. I will think about you next time I have to fix one of these 1% pathname bugs you do not seem to be concerned about, which tend to happen all the time when your program is used by many people with many files (i.e. the case every developer hopes for)

Re:String types in Rust by spotman on Tuesday March 29, 2016 @02:07AM (#11379763)
Yea the last 1% is the most fun and difficult.

One of the projects I am working on lately is a data integrity and syncing platform with multiple PB of data in multiple data centers, and the dataset has been around for 10-12 years.

Some of the file names and path names I see have the most unnatural and unbelievable characters in them.

It can absolutely be quite a challenge. This point about rusts string system sounds like maybe could give me some very precise control.

Re:String types in Rust by oldmanjay on Monday March 28, 2016 @07:00PM (#11378153)
I definitely fall on the other side of the fence, philosophically. Perhaps I've just fixed too many of those "trust me" bugs that programmers are constantly adding into code I have to maintain. I'm especially over the thinking that sufficient vigilance is something we should rely on humans to achieve when the computer is way, way better at it.
Re:String types in Rust by lmm on Tuesday March 29, 2016 @06:20AM (#11380526)
> I have never ever had bugs in my code from somehow having invalid Unicode code-points in my paths.

Do you use any computers with non-unicode filesystems? I hit such a bug every month or two. (Most recently a couple of days ago in Deluge, for a concrete example, which seems to not open .torrent files with non-unicode filenames). If you're actually using a computer with a non-unicode filesystem at all regularly then I'm honestly amazed you haven't seen such bugs.

> I realize certain classes of bugs could happen, but I'd rather take that risk, have a bug, and fix it, than burden the type system and libraries.

It's a question of costs and benefits, no? A particular class of bugs has severity x and happens at rate y. If the language is such that the type system and libraries can handle it at a cost of less than xy (in terms of complicating or slowing development) then it's worth handling it there; if not, not.

> In a way, I'm a little sad that modern computer languages are going from C's extreme of "always trust the programmer" to the other of "never trust the programmer". Bugs are bad, but language usability, ease-of-use and simplicity are also worth fighting for.

Language usability, ease-of-use and simplicity are absolutely valuable. A good language is one that allows you to write correct programs without sacrificing those things.

I find a language that will keep track of things for me is a actually huge help in writing correct code. E.g. if I'm writing Python 2 then I still have to worry about whether a particular object is a string or a byte sequence - worse, I have to do all the work of keeping track of it in my head, because the language will just silently corrupt data if I get it wrong. I end up writing comments on my functions that say what a particular value is, and carefully reading my code to verify I've made encode()/decode() calls in the right places. I don't want my language to "trust me", any more than I'd want to e.g. try to cut a piece of wood to the right length without measuring or marking it first.

Re:String types in Rust by douche on Tuesday March 29, 2016 @07:17AM (#11380681)
Out of curiosity, what would be some examples of computers with non-unicode filesystems? I'm scratching my head trying to come up with anything other than old, old legacy systems that used EBCDIC.
Re:String types in Rust by the_why_of_y on Tuesday March 29, 2016 @02:41PM (#11383786)
POSIX does not require any particular encoding of file names. File names are not even required to be text, just a sequence of bytes; the only forbidden bytes are '\0' and '/'.

http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_...

Re:String types in Rust by lmm on Wednesday March 30, 2016 @04:16AM (#11387714)
Sure - but concretely, what specific systems have non-unicode filesystems? I know a lot of linux distributions allow you to choose a different encoding if you want, but the defaults push you towards UTF-8.
Re:String types in Rust by lmm on Tuesday March 29, 2016 @07:42AM (#11380765)
Windows.

(Many of the western codepages are either subsets of UTF-8, or not actually UTF-8 but can roundtrip through UTF-8 so you don't actually notice the difference as long as the program is just using the filename as an opaque "handle" and not actually manipulating it. In my case my filesystem is Shift-JIS for compatibility with some old Japanese programs, and that doesn't roundtrip cleanly through unicode)

Re:String types in Rust by dllthomas on Monday March 28, 2016 @09:15PM (#11378866)
This is not "never trust the programmer", it's "do we hand the programmer a broken library?"
Re:String types in Rust by rkangel on Tuesday March 29, 2016 @06:19AM (#11380523)
The problem is that C's case of "always trust the programmer" has proven over time not to be sufficient. This is particularly true for security bugs.

The major driver behind Rust's design is memory safety - make it impossible (or very difficult) for certain classes of bugs to exist. You can write C software that is reliable without that safety, but it is very time consuming and never perfect.

This is a similar situation - give the programmer tools to write "obviously" correct code.

Re:String types in Rust by Dylan16807 on Monday March 28, 2016 @07:55PM (#11378486)
Fixing a handful of programs that way is already more expensive than putting it in the language.
Re:String types in Rust by Retra on Tuesday March 29, 2016 @03:03AM (#11379952)
You shouldn't have to roll your own (likely incorrect) path validation code every time you handle a file. This is something just about every program does. There are standard ways of doing this, and those standards can be done in a standard library.