News for hackers. Stuff that matters.
Re:More code review tools by nightpool on Tuesday March 15, 2016 @03:05PM (#11292163)
Question: why do you use checklists to assign reviewers, when github has that functionality built in?
Re:More code review tools by jbrooksuk on Tuesday March 15, 2016 @04:25PM (#11292692)
Because GitHub only allows you to assign to one person per issue.
Re:More code review tools by nightpool on Tuesday March 15, 2016 @11:13PM (#11294723)
Wait really? I could have sworn this wasn't true... Must have gotten confused somewhere
Re:More code review tools by danpalmer on Tuesday March 15, 2016 @04:50PM (#11292873)
1) jbrooksuk's answer, only one assignee. 2) Assignees are the person owning the changes, not the person reviewing. 3) There is no status associated with it, you can't say "checked" vs "unchecked", and certainly not unreviewed/accepted/rejected.