News for hackers. Stuff that matters.
Re:Hacker News CSRF Vulnerability by Osiris on Thursday February 25, 2016 @04:23PM (#11177912)
So what was the fix? I don't see a CSRF token in the login page, so I'm curious what their patch was.
Re:Hacker News CSRF Vulnerability by philmander on Thursday February 25, 2016 @04:42PM (#11178061)
The logout link is rendered with the token in its query string
Re:Hacker News CSRF Vulnerability by VoidWhisperer on Thursday February 25, 2016 @05:19PM (#11178292)
Wouldn't this still allow logging in without consent if they aren't logged in?
Re:Hacker News CSRF Vulnerability by dang on Thursday February 25, 2016 @07:47PM (#11179106)
It does. We haven't rolled out the fix that Nick described (https://news.ycombinator.com/item?id=11178922) because it will probably break a bunch of the third party apps and scrapers that give people alternative interfaces to HN. Those have value and I'd rather not make their lives more difficult unless/until it's necessary.
Re:Hacker News CSRF Vulnerability by qjighap on Friday February 26, 2016 @07:36AM (#11181051)
Finally, some clarification on which hacker news it is. I care less about the hacker news with the "the"
Re:Hacker News CSRF Vulnerability by Osiris on Thursday February 25, 2016 @06:03PM (#11178559)
I have implemented CSRF for the public API I work on and all PUT/POST requests require the CSRF token, not GET requests. In this case, the login form uses a POST request and thus must require a CSRF token to avoid an attack on users that aren't logged in.
Re:Hacker News CSRF Vulnerability by kogir on Thursday February 25, 2016 @07:51PM (#11179125)
What stops an attacker from requesting the CSRF token?
Re:Hacker News CSRF Vulnerability by r1ch on Thursday February 25, 2016 @08:10PM (#11179204)
Same-origin policy.
Re:Hacker News CSRF Vulnerability by kogir on Thursday February 25, 2016 @08:52PM (#11179350)
That only applies to browsers. I can request it from my server just fine. See https://news.ycombinator.com/item?id=11178922