scottnonnenberg

You seem pretty passionate - wanna help us test proxy and system tray support?

Tray support behind command-line argument: https://github.com/signalapp/Signal-Desktop/pull/1676

Proxy support behind command-line argument: https://github.com/signalapp/Signal-Desktop/pull/1878

Feel free to reach out. :0)

Yep, as I mention down-thread, merges only happen at GitHub/GitLab/etc.

The two mistaken scenarios I run into the most are:

1. `git pull` when I'm not in the right branch, which will want to do a merge.

2. When I have commit access on the master branch, and I do a `git merge branch` when that branch hasn't been properly rebased on master. My preference is no merge commit here, so I like that Git can catch this.

Wouldn't it make sense to turn that off per-project when you encounter it?

My local configuration doesn't need to be ready to create merge commits because those happen on GitHub/GitLab/etc. When I rebase, it's my own pull request on top of a more recent master - the signer remains me.

Oh, I certainly agree that coding standards are important. Consistency of coding style makes a codebase substantially more approachable. I'm just interested in making that as automated as possible: https://blog.scottnonnenberg.com/eslint-part-3-analysis/