rantouan

So I had assumed that in my case I'm alright. Do you see any change needed that I can't see ?

---

Maybe a good idea would had been to go by platform or architecture and use some macros to do the check only if it's really needed. What do you think of it ? How would you implement it ?

You can make a pull request as well.

I added now a "/** * * */" separator to make it even more clear.

I don't know, but I like separating things like that, I think it's handy for cases like now that setting the errno was kind of mixed with vars initialization.

```

    errno = 0;

    char *strtolEndptr;
    ...

    errno = 0;

    /*** * * ***/

    char *strtolEndptr;
    ...

->

https://sourceware.org/ Links table on the left -> "GLIBC" button

->

https://sourceware.org/glibc/ Top menu -> "sources"

->

https://sourceware.org/glibc/sources.html "gitweb" link

->

https://sourceware.org/git/?p=glibc.git Top menu -> "tree" link

->

https://sourceware.org/git/?p=glibc.git;a=tree Tree -> "stdlib" link

->

https://sourceware.org/git/?p=glibc.git;a=tree;f=stdlib;h=93... Tree -> "atoi.c" row -> "raw" link

->

https://sourceware.org/git/?p=glibc.git;a=blob_plain;f=stdli...

``` /* Convert a string to an int. / int atoi (const char nptr) { return (int) strtol (nptr, (char *) NULL, 10); } libc_hidden_def (atoi) ```