News for hackers. Stuff that matters.

martinvanaken

Re:PullReview – Automated Code Review for Ruby in GitHub on Sunday February 09, 2014 @02:08PM (#7206627)
Hi Sheff, I'm Martin, co-founder of PullReview. I'm interested in understanding why the SaaS is not a good solution for you. Is it because you are not using GitHub (or any other online forge)?

Thanks for your interest anyway.

Martin

Re:We don’t have time for code reviews on Wednesday October 23, 2013 @01:03PM (#6600038)
+1 to that one. Code Review should be Peer Review - it is not about a Senior reviewing a Junior it is about a developer reviewing the work of another one. The junior's questions may actually be as useful as advices (notably by forcing you to explain your choices).
Re:We don’t have time for code reviews on Wednesday October 23, 2013 @01:01PM (#6600026)
Thanks, nice list, summarize a good part of the best practices in a short form. Will quote.
Re:We don’t have time for code reviews on Wednesday October 23, 2013 @12:52PM (#6599952)
Hi, author here. I agree this may not be easy - but something can always be done. I've been in several situation.

As a team leader facing junior developers, I did simply set-up rules. I explained them, but I had the power to enforce them by myself. I coded with them, and they started coding like me - until they were confident enough to challenge me. I apologize to the "autonomous self organizing teams" evangelists, but in some situations, giving some direction may be the most efficient way to progress.

As a peer, you just need to find one other person in your team that is willing to play along. Although I understand the value in explaining something, doing it is for me much more convincing. If you really think something is a good practice, don't try convincing me if you are not already applying it yourself.

If you are in an Agile/sprint oriented team, just propose to test it for one sprint, then it will pass the retrospective test or it will not - no one should object to a one sprint experience, especially in an agile team. Do the same with your colleagues ideas, even if you find them silly. It shows goodwill, and you can be surprised at some time.

This is actually the way me arrived to our current workflow at 8th color (http://blog.8thcolor.com/2013/09/how-our-own-workflow-is-dri...) - successive retrospectives.

Finally I would not involve non coding management in the discussion if possible, as it will quickly devolve into "what would it cost". Better to handle this inside the technical team.

Hope it helps, and remember, it's the first step that cost. Find one willing colleague and start!

Martin

Re:We don’t have time for code reviews on Wednesday October 23, 2013 @11:55AM (#6599488)
Great list (especially "off the top of your head"). Thanks a lot for sharing. Several of those can actually be implemented in an automated tool (styles, short variables, spacing, unused variables even). What's your take on automated tools? (Disclaimer: my company built one - pulreview.com).
Re:We don’t have time for code reviews on Wednesday October 23, 2013 @11:37AM (#6599365)
I agree with you, and this is the reason why having small features and reviews for all of them helps. Groking a colleague's code is much simple if it is a small piece, and when you are reviewing his code regularly (and the other way around).

Our typical PR is 1-2 days of work, so I'm reviewing several by week, something by days.

You are of course right that it should not fall into "you should do it my way". Now, when my colleague said "I would have done it differently", I always ask how and why. I will probably not change my code if it is good (or even good enough), but I would have learned something, or got another point of view.

Re:We don’t have time for code reviews on Wednesday October 23, 2013 @11:10AM (#6599183)
Its the whole point for me: even if I prefer managers that I can convince, I just call that "development". Replace: "feature is done but need to be tested or reviewed" by "feature is not done".

The fall in the technical/developer responsibility anyway for me.

Re:We don’t have time for code reviews on Wednesday October 23, 2013 @11:06AM (#6599159)
Hi, OP here. Interesting list. I think I would approve most of your points, but never worked (or created) such a "proper" environments in my various teams. Could you share the kind of checklist you use? Or give an idea of the kind of "checks" you have there?

Thanks!

Re:We don’t have time for code reviews on Wednesday October 23, 2013 @09:52AM (#6598695)
This one should be recorded on http://www.codingconfessional.com/
Re:We don’t have time for code reviews on Wednesday October 23, 2013 @09:51AM (#6598686)
Hi, I think both are actually useful. The CI is supposed to run the tests (even if I like to run some myself when reviewing), but I agree that starting the application is a part of the review - you should not stop at just looking at the code (but just startint the application does not cut it either for me).

Martin (OP)

Re:Technical founders have nothing to lose on Wednesday December 19, 2012 @08:43AM (#4942493)
My point (as another commenter pointed), was more that, as long as you do not put a lot of money in, you'll have ample opportunities to recover, even in the worst case. Especially in the market we are in. This does not invalid your point, as I agree that there is plenty of jobs and money to do around here in the sector.

Older »