jacksingleton
I'll think about ways to make it more clear! Thanks
@franciscop -- keep an eye out for the rest of the article (it's already written and will be released soon). I go over the impacts of an attacker knowing the secret in much more detail. I also have sections on prevention for both application developers and library/framework authors that I think you'll find interesting!
File on master: https://github.com/jacksingleton/cr-newline-diff-test/blob/m... File in pull request: https://github.com/jacksingleton/cr-newline-diff-test/blob/v...
Note the diff does not show "print 'did you see this coming?'" as a change - yet once merged python will run it with no problems.
Interestingly, if you hit expand at the bottom left, you will see "print 'did you see this coming?'" in both the master and the PR version... which is not the case.
Remember to review PRs in git, not GitHub - especially if you're working on sensitive software!
CR bug in GitHub diff lets people hide code in PRs
[1] your browser
I must admit though I AM mutable and globally accessible