Passing a null pointer to free() is perfectly safe, and in this case simplifies the cleanup code.
Although the concern of a memory leak is valid. I would have expected the resources to be free'd regardless of the result.
Re:Things Rust shipped without
by luso_brazilian on Friday July 03, 2015 @07:59PM
(#9828550)
Of course, you are right. I seem to have carried the belief that freeing a null pointer was as bad as freeing one twice. And now I know.
Seems to be a common misconception [1], thanks for pointing out, that makes the GGP code correct in all counts and my switch redundant.
Or you could simply free resource1 and resource2 even if the allocation failed. free(NULL) is defined to do nothing.
Re:Things Rust shipped without
by TheLoneWolfling on Friday July 03, 2015 @09:23PM
(#9828764)
Except of course that many languages seem to be trying to remove fallthroughs from switches too...
A way to fix it would be to return different failures for every allocation and to use a switch without a break to clean up, something like:
EDIT: added potential fix to the code. Sorry if there is any bug in the fix, my C is a little bit ... rusty.EDIT2: fixed a bug in the fix. C is hard, let's go shopping.
EDIT3: the explanation for the bug was also wrong. It is not a memory leak for but freeing a null pointer. Fixed too.