Re:Clarity - an open source web interface to grep and tail
by tptacek on Sunday December 06, 2009 @05:45PM
(#980288)
No, the most insecure things invented by people take URL parameters from unauthenticated requests and run them on the command line.
I didn't audit the code or anything, but all the request processing is gated by a function that requires HTTP basic-auth, which is at least hard to screw up. To accidentally add a function that bypasses auth, they'd have to write an entire new request handler chain.
That said, I noticed the same thing (popen), and if I was going to integrate this with our product, I'd hardcode the command line.
I didn't audit the code or anything, but all the request processing is gated by a function that requires HTTP basic-auth, which is at least hard to screw up. To accidentally add a function that bypasses auth, they'd have to write an entire new request handler chain.
That said, I noticed the same thing (popen), and if I was going to integrate this with our product, I'd hardcode the command line.