News for hackers. Stuff that matters.
Re:Commit messages are not titles by anton_gogolev on Tuesday June 23, 2015 @06:04AM (#9763623)
Regardless of whether commit messages are in past or present tense, have trailing period or not, properly capitalized or not -- they are all equally unreadable with all the "Merge pull request #20552 from jamesdabbs/belongs-to-polymorphic-force-reload" junk.
Re:Commit messages are not titles by harperlee on Tuesday June 23, 2015 @07:19AM (#9763886)
Yeah, that's something that I never understood. The most important information is not that this is a merge, but the intent of the branch. You can give extra detail in the extended part, but the title should not be just referencing the way in which those changes found their way to the branch, and not what they do as in the rest of commits...
Re:Commit messages are not titles by gknoy on Tuesday June 23, 2015 @01:51PM (#9766350)
I believe Github lets one add extended commit messages for merge commits. Most of us (including me) tend to ignore that and use the autogenerated one. It'd be nice if we had an easy option to automatically include the PR's description (first comment) as the merge commit's message.
Re:Commit messages are not titles by djur on Tuesday June 23, 2015 @10:20AM (#9764773)
`git log --no-merges` saved me a lot of headaches after switching to a pull request-based review model at work.