Re:How the PVS-Studio Team Improved Unreal Engine's Code
by tinco on Friday June 19, 2015 @08:49PM
(#9748482)
Code like this is painful to unit test, so it often plainly isn't unit tested.
So then comes the question why was it not detected in production (there's a good chance that there's games out there that have shipped with that line in there). Memcmp doesn't have any side effects, so instead of something updating, something just doesn't update. The function is called 'Optimize', perhaps it just calculates a more optimal dataset, and then does nothing with it, leaving the unoptimized data in there. No one would notice and some path would just be slightly less optimal.
So then comes the question why was it not detected in production (there's a good chance that there's games out there that have shipped with that line in there). Memcmp doesn't have any side effects, so instead of something updating, something just doesn't update. The function is called 'Optimize', perhaps it just calculates a more optimal dataset, and then does nothing with it, leaving the unoptimized data in there. No one would notice and some path would just be slightly less optimal.