News for hackers. Stuff that matters.
Re:Code Review Best Practices by Cymen on Sunday May 10, 2015 @12:58AM (#9518883)
I agree 100% with the "don't be a blocker." I personally look for about 80-90% yes and if it meets that criteria with no errors, I thumb it up. If I can't thumb it up, I try to put a "thumbs up with commented items fixed". I try to not block -- comment for bad issues, sometimes sigh but agree when it's a 10% disagreement and go forward. Life is a series of iterations. That 10% will be addressed in a future iteration.

And I never close another persons PR.

There are no comments on this comment yet.