Code Review Best Practices

Re:Code Review Best Practices by halostatue on Sunday May 10, 2015 @12:34AM (#9518820)

Go have coffee (or whatever) with your colleague and have a 1-to-1 conversation with them saying you want their feedback on code. You want their expertise to make you a better software developer. Even if you are better at this than they are, you can learn something from the sharing.

The team’s lead should make sure that the individual in question knows that software development is a cooperative process and that code review helps build the team.

[ Parent | on HN ]

Re:Code Review Best Practices by MaulingMonkey on Sunday May 10, 2015 @12:43AM (#9518839)

This. Although I'm less civil about it - I'll start giving people shit for rubber stamping my code reviews.

"Why are you letting me ship this terrible code I wrote? Do you want us to end up in a death spiral of technical debt and crunch? Don't be an asshole, critique my shit! We all need a second set of eyes - I'm no exception!"

...okay, I'm maybe a little more civil than that. But I'm not above leaving some mistakes unfixed to call them out on.

[ Parent | on HN ]

Re:Code Review Best Practices by garthk on Sunday May 10, 2015 @01:49AM (#9519002)

Ha! I'm like that with my QA people, begging them to come after me with a blunt weapon.

[ Parent | on HN ]