News for hackers. Stuff that matters.
Re:Code Review Best Practices by acveilleux on Saturday May 09, 2015 @10:02PM (#9518466)
If you can't understand what UsedToBeSomeMassiveFunction() does from the SubFunctionK()'s names and arguments, they were not split out correctly.

Often I find the best way to simplify large functions is to tear out sub-blocks and give them name. Loops or large conditional blocks are usually easy to tear out and can usually get very meaningful names. Long stretch of imperative code however does not separate well and probably should remain a very large function.

Re:Code Review Best Practices by arthurjj on Saturday May 09, 2015 @10:35PM (#9518556)
"Long stretch of imperative code however does not separate well and probably should remain a very large function."

As someone who uses Resharper's Extract Method a lot this is a nice counterexample to where it's probably inappropriate