Re:Functional Programming in Haskell by Examples
by M00n_Sl47r on Monday April 27, 2015 @03:43PM
(#9448646)
The grammar in this is a bit off. I'll probably submit a pull request with some edits, if that's something people do? I'm not sure about the etiquette surrounding grammar mistakes in a github repo.
[ Parent
| on HN ]
Re:Functional Programming in Haskell by Examples
by jonreem on Monday April 27, 2015 @04:09PM
(#9448779)
Personally I am always thrilled to get grammar/typo fix pull requests to my projects. It means someone cared enough about the project to go through the effort of making a PR just to alleviate a small aesthetic problem!
Re:Functional Programming in Haskell by Examples
by creichert on Monday April 27, 2015 @04:08PM
(#9448772)
I think it's a nice gesture as long as you are polite about it. I would be happy that someone read the content and wanted to help improve it.
Re:Functional Programming in Haskell by Examples
by bontoJR on Monday April 27, 2015 @05:05PM
(#9449071)
Definitely a good habit, I think more than the 50% of Github users are not English as mother tongues, so it's good to polish documentations, or like in this case, long texts. I always accept pull-requests for grammar improvements.