News for hackers. Stuff that matters.
Re:Automated code review for Python, Django, etc. by ThePhysicist on Monday April 27, 2015 @10:42AM (#9446594)
Good point! When asking developers about their use of static code analysis to ensure code quality we found that most development teams use such tools only sporadically or not at all, and just very few teams have a systematic process or set of guidelines for ensuring code quality throughout all of their projects. So while some technologies already exist for this, we definitely think that there's room for more.
Re:Automated code review for Python, Django, etc. by gknoy on Monday April 27, 2015 @12:03PM (#9447140)
I'm not a fan of pre-commit hooks (as I'd rather write it, lint it, fix-rebase-it), but I love having a CI suite that includes the linting tests that our team has agreed on. It lets me code away and lint things when I'm ready to make my pull requests.
Re:Automated code review for Python, Django, etc. by jquast on Monday April 27, 2015 @12:51PM (#9447495)
agreed, git hooks are a terrible place, they can actually impede progress and can also be skipped/disabled/never installed in the first place.

The time for rejecting a build for linting is at time of merge to trunk/next release, which a good CI should already have checked.

Re:Automated code review for Python, Django, etc. by ThePhysicist on Monday April 27, 2015 @01:31PM (#9447812)
yeah that's the workflow we have in mind as well:

-make changes in a feature branch

-have the linter run on each commit to see if there are problems

-when you make a pull request, check the code again and comment on the PR if there are any problems.