Re:Race conditions on Facebook, DigitalOcean and others (fixed)
by some1else on Monday April 27, 2015 @06:03AM
(#9445280)
A simple Discount domain model with validations:
Class Discount
belongs_to :promo_code
belongs_to :customer
belongs_to :order
validates_presence_of :promo_code, :customer, :order
validates_associated :promo_code
validates_uniqueness_of :promo_code_id, :scope => [:customer_id, :order_id]
end
Limiting down to a single Promo-code per order: Class Discount
# ...
validates_uniqueness_of :order_id, :scope => :customer_id
end
Re:Race conditions on Facebook, DigitalOcean and others (fixed)
by gavingmiller on Monday April 27, 2015 @09:57AM
(#9446281)
This right here is the heart of race condition bugs, and is NOT race condition safe. When running multiple web servers and without a "validates_uniqueness_of" constraint on your database, multiple requests hitting multiple different web servers can claim multiple discounts for the same user. Problem only grows as your number of web servers grow!
Re:Race conditions on Facebook, DigitalOcean and others (fixed)
by kawsper on Monday April 27, 2015 @02:24PM
(#9448199)
Read the part "Concurrency and integrity" in the Rails documentation: http://apidock.com/rails/ActiveRecord/Validations/ClassMetho...
You need to enforce the uniqueness in the DB.
If you introduced some combination of a user ID and promo code, then it won't prevent a race of one user firing many queries with different promo codes and stacking them up. It would, however, fix the original problem.