News for hackers. Stuff that matters.
Re:Null Pointer Dereferencing Causes Undefined Behavior by kstenerud on Monday April 20, 2015 @06:00PM (#9411120)
No, the problem comes from the assumption that you can legally fetch the "address" of a structure member via pointer dereference without checking for null so long as you don't actually try to access the resulting address.

    struct usb_line6 *line6 = &podhd->line6;
The assumption is that this is OK so long as you don't try to access the contents of line6 without doing some upstream null checking first. This assumption is false. The very act of dereferencing is undefined, regardless of whether you access the resulting address or not.

The assumption fails whether null is implemented as 0, 200, 0x8000000000000000, 0xffffffffffffffff.

Re:Null Pointer Dereferencing Causes Undefined Behavior by ploxiln on Monday April 20, 2015 @09:12PM (#9411777)
There was no actual dereferencing, this is just pointer arithmetic. it's "line6 = podhd + offset". There isn't really a better way to do it.
Re:Null Pointer Dereferencing Causes Undefined Behavior by kstenerud on Tuesday April 21, 2015 @10:56AM (#9414436)
Most underlying implementations won't actually dereference here (which is why it usually works), but as far as the spec is concerned, you are dereferencing it, which is undefined.

That becomes a problem with modern optimizing compilers, because they make assumptions about your code based on what's allowed according to the spec.

Re:Null Pointer Dereferencing Causes Undefined Behavior by ehmmm on Monday April 20, 2015 @09:19PM (#9411797)
There is no pointer arithmetic in the line:

    struct usb_line6 *line6 = &podhd->line6;
Offset is calculated "below the hood". Pointer arithmetic is defined with arithmetic operands: +,-

-> and . are not arithmetic operands.

Re:Null Pointer Dereferencing Causes Undefined Behavior by jwatte on Monday April 20, 2015 @10:58PM (#9412044)
You sound very sure of yourself.

If you look at the definition of the -> and [], you might learn something!

Re:Null Pointer Dereferencing Causes Undefined Behavior by ehmmm on Tuesday April 21, 2015 @12:41AM (#9412313)
Clearly, you don't have anything constructive to say, so you have to resort to ad hominem.

[] operator doesn't have any place in this debate.

Re:Null Pointer Dereferencing Causes Undefined Behavior by spoiler on Tuesday April 21, 2015 @06:16AM (#9413094)
Well, as far as I understand it, `->` works in a similar fashion to `[]`; the difference being that one behaves on arrays while the other on structs.

What @jwatte tried to say is that `->` works like this:

    // foo is struct thingity*
    &foo->bar == foo + offsetof(struct thingity, bar);
The `[]` does a similar thing:

    // s is char*
    *(s+i) == s[i]
Re:Null Pointer Dereferencing Causes Undefined Behavior by ehmmm on Tuesday April 21, 2015 @08:42PM (#9418042)
Sure, &foo->bar looks like foo + offsetof(struct thingity, bar), but there is no pointer arithmetic involved since C doesn't specify how the member access ( -> or . ) is actually calculated.

It does however specify that [] operator is equivalent to pointer arithmetic. But we are talking ->,. operators and not [].