Re:Generate Your Changelog From GitHub Issues
by akerl_ on Friday March 20, 2015 @08:28AM
(#9237226)
In my experience, one of the upsides of GitHub and similar services is that they drastically lower the process headache of merging patches.
When merging a patch means getting it out of the email and applying it to your branch, confirming it's valid / what changed, running your tests, then merging and pushing up the new version, it's quick to see why single-character or grammar/spelling fixes can be a burden.
With GitHub, I can see the PR, the diff, whether it'll merge cleanly, and whether my TravisCI tests pass right from the PR's page, and all I need to do is hit the Merge button. It makes me much more likely to review/merge PRs.
No, it's not rude. For me personally, I just think it's great that someone else was interested in the code. I would venture a guess that 95% of the ESL speakers I know just want to get better, and would love to be corrected.
Re:Generate Your Changelog From GitHub Issues
by impostervt on Friday March 20, 2015 @08:16AM
(#9237189)
Just my opinion, but I don't think it would be rude. Even thought I KNOW it's not really relevant, I've caught myself trusting some projects less if the Readme isn't well written.
Re:Generate Your Changelog From GitHub Issues
by evantahler on Friday March 20, 2015 @09:05AM
(#9237381)
I'm a native english speaker who just happens to be a terrible speller. I consider it a measure of project success when someone who isn't a native english speaker corrects me :D
Re:Generate Your Changelog From GitHub Issues
by skywinder on Friday March 20, 2015 @08:38AM
(#9237265)
Yep. I know, my english is not well. So, I will much apreciate a PR with grammar fixes.
Re:Generate Your Changelog From GitHub Issues
by scrapcode on Friday March 20, 2015 @08:48AM
(#9237314)
Your English is just fine. Excellent, even, for being a second language.
Re:Generate Your Changelog From GitHub Issues
by duaneb on Friday March 20, 2015 @11:16AM
(#9238205)
In this case, you'd want 'good' instead of 'well'—your english is good and you speak english well.
Re:Generate Your Changelog From GitHub Issues
by skywinder on Friday March 20, 2015 @12:46PM
(#9238737)
Good to know! :) Thanks!
Re:Generate Your Changelog From GitHub Issues
by xomateix on Friday March 20, 2015 @08:37AM
(#9237262)
As a non native english speaker I would really appreciate any correction.
Re:Generate Your Changelog From GitHub Issues
by omahlama on Friday March 20, 2015 @08:20AM
(#9237205)
That sort of thing happens all the time on stackoverflow, where most of the users aren't native English speakers. Go for it!
Re:Generate Your Changelog From GitHub Issues
by tessierashpool on Friday March 20, 2015 @11:28AM
(#9238282)
I do it all the time, most people seem to like it. I usually apologize for being "that guy," though, because I don't want anyone taking it personally.
This is a serious question for HN: Is it considered rude to make pull requests to fix grammar? The English is great, but is made more apparent in some locations (such as headers in the README) that it is a second language, but the first thing I thought to myself was "that'd be rude".