I guess it's really hard to be idiomatic in 23 languages.
Python is one of the oldest implementations and I ought to do a another pass through to clean it up sometime.
I'm happy to take pull requests that make an implementation shorter and/or more idiomatic as long as it doesn't change the overall order/flow (and doesn't break any of the tests of course).
`core` has inline lambdas in Ruby:
but separately defined ones in Python Note that `return None` isn't needed - Ruby doesn't have it, so that's a "wasted" line. The function should also be more like or, if Python 2 support wasn't needed, Defining these out-of-line is a good idea, though (it improves introspection in Python).`mal_readline` has a bit of support for Python 2 which takes a few lines, but mostly it's code like
versus The Python code handles errors but has two pointless `pass` statements and a couple of odd choices. It should better be: Note that the Python uses lazy reading which is why it needs explicit closing; Ruby likely would too if it read lazily.I have no idea what's up with `mal_types`/`types`; Ruby does simple stuff and then Python does... something. I will say that the Python can be a lot simpler at minimum, although I'd need to grok what it does before I can say what. For example,
can be replaced with I think the `_Q` suffix is a the writer missing Ruby's `?`-suffixes on identifiers.There's also a lot of mess that I think arises because the writer might not be aware that you can make callable objects in Python.
I think in the end it comes down to language experience. My Ruby would probably look as hacky as Joel Martin's Python. I doubt there would be as large a difference if they were both written with the same language familiarity.